linux-kernel - Re: [PATCH net-next v4 04/12] net: pcs: add Renesas MII converter driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220510092410.1c1f5eaa@xps-bootlin>
Date:   Tue, 10 May 2022 09:24:10 +0200
From:   Clément Léger <clement.leger@...tlin.com>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Herve Codina <herve.codina@...tlin.com>,
        Miquèl Raynal <miquel.raynal@...tlin.com>,
        Milan Stevanovic <milan.stevanovic@...com>,
        Jimmy Lalande <jimmy.lalande@...com>,
        Pascal Eberhard <pascal.eberhard@...com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4 04/12] net: pcs: add Renesas MII converter
 driver

Le Mon, 9 May 2022 21:20:30 +0100,
"Russell King (Oracle)" <linux@...linux.org.uk> a écrit :

> Hi,
> 
> On Mon, May 09, 2022 at 03:18:52PM +0200, Clément Léger wrote:
> > +#define MIIC_PRCMD			0x0
> > +#define MIIC_ESID_CODE			0x4
> > +
> > +#define MIIC_MODCTRL			0x20
> > +#define MIIC_MODCTRL_SW_MODE		GENMASK(4, 0)
> > +
> > +#define MIIC_CONVCTRL(port)		(0x100 + (port) * 4)
> > +
> > +#define MIIC_CONVCTRL_CONV_SPEED	GENMASK(1, 0)
> > +#define CONV_MODE_10MBPS		0
> > +#define CONV_MODE_100MBPS		BIT(0)
> > +#define CONV_MODE_1000MBPS		BIT(1)  
> 
> I think this is an inappropriate use of the BIT() macro. BIT() should
> be used for single bit rather than for field values.
> 
> You seem to have a two bit field in bits 1 and 0 of a register, which
> has the values of:
> 0 - 10MBPS
> 1 - 100MBPS
> 2 - 1GBPS
> 
> I'd guess 3 is listed as "undefined", "do not use" or something
> similar?

You are right, this is actually values rather than individual bits.

> 
> > +
> > +#define MIIC_CONVCTRL_CONV_MODE		GENMASK(3, 2)
> > +#define CONV_MODE_MII			0
> > +#define CONV_MODE_RMII			BIT(0)
> > +#define CONV_MODE_RGMII			BIT(1)  
> 
> This looks similar. a 2-bit field in bits 3 and 2 taking values:
> 0 - MII
> 1 - RMII
> 2 - RGMII
> 
> ...
> 
> > +static int miic_config(struct phylink_pcs *pcs, unsigned int mode,
> > +		       phy_interface_t interface,
> > +		       const unsigned long *advertising, bool
> > permit) +{
> > +	u32 speed = CONV_MODE_10MBPS, conv_mode = CONV_MODE_MII,
> > val;
> > +	struct miic_port *miic_port =
> > phylink_pcs_to_miic_port(pcs);
> > +	struct miic *miic = miic_port->miic;
> > +	int port = miic_port->port;
> > +
> > +	switch (interface) {
> > +	case PHY_INTERFACE_MODE_RMII:
> > +		conv_mode = CONV_MODE_RMII;
> > +		speed = CONV_MODE_100MBPS;
> > +		break;
> > +	case PHY_INTERFACE_MODE_RGMII:
> > +		conv_mode = CONV_MODE_RGMII;
> > +		speed = CONV_MODE_1000MBPS;
> > +		break;
> > +	case PHY_INTERFACE_MODE_MII:  
> 
> I'm not sure why you need to initialise "speed" and "conv_mode" above
> when you could set them here.

It only seemed to me that 0 value was the default init one but I'll
move that in that case.

> 
> Thanks. 
>