linux-kernel - [jsarha:topic/cros-sof-v4.19 1074/6555] drivers/gpu/drm/drm_syncobj.c:125:6: warning: no previous prototype for function 'drm_syncobj_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202205101535.GWoZC8wP-lkp@intel.com>
Date:   Tue, 10 May 2022 15:42:37 +0800
From:   kernel test robot <lkp@...el.com>
To:     Daniel Vetter <daniel.vetter@...ll.ch>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Jason Ekstrand <jason@...kstrand.net>,
        Sean Paul <seanpaul@...omium.org>,
        Stéphane Marchesin <marcheu@...omium.org>,
        "Kristian H. Kristensen" <hoegsberg@...omium.org>
Subject: [jsarha:topic/cros-sof-v4.19 1074/6555]
 drivers/gpu/drm/drm_syncobj.c:125:6: warning: no previous prototype for
 function 'drm_syncobj_add_callback'

tree:   https://github.com/jsarha/linux topic/cros-sof-v4.19
head:   d7a3e91d8d16d1ef8653deec5a1fffc4de034a0c
commit: 8e82fa1ed837aefa829a82894a950e7abc393536 [1074/6555] UPSTREAM: drm/syncobj: Drop add/remove_callback from driver interface
config: x86_64-randconfig-a003-20220509 (https://download.01.org/0day-ci/archive/20220510/202205101535.GWoZC8wP-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 18dd123c56754edf62c7042dcf23185c3727610f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/jsarha/linux/commit/8e82fa1ed837aefa829a82894a950e7abc393536
        git remote add jsarha https://github.com/jsarha/linux
        git fetch --no-tags jsarha topic/cros-sof-v4.19
        git checkout 8e82fa1ed837aefa829a82894a950e7abc393536
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/drm_syncobj.c:125:6: warning: no previous prototype for function 'drm_syncobj_add_callback' [-Wmissing-prototypes]
   void drm_syncobj_add_callback(struct drm_syncobj *syncobj,
        ^
   drivers/gpu/drm/drm_syncobj.c:125:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void drm_syncobj_add_callback(struct drm_syncobj *syncobj,
   ^
   static 
>> drivers/gpu/drm/drm_syncobj.c:134:6: warning: no previous prototype for function 'drm_syncobj_remove_callback' [-Wmissing-prototypes]
   void drm_syncobj_remove_callback(struct drm_syncobj *syncobj,
        ^
   drivers/gpu/drm/drm_syncobj.c:134:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void drm_syncobj_remove_callback(struct drm_syncobj *syncobj,
   ^
   static 
   2 warnings generated.


vim +/drm_syncobj_add_callback +125 drivers/gpu/drm/drm_syncobj.c

e7aca5031a2fb5 Jason Ekstrand 2017-08-25  124  
9c19fb10a5893d Jason Ekstrand 2017-08-28 @125  void drm_syncobj_add_callback(struct drm_syncobj *syncobj,
9c19fb10a5893d Jason Ekstrand 2017-08-28  126  			      struct drm_syncobj_cb *cb,
9c19fb10a5893d Jason Ekstrand 2017-08-28  127  			      drm_syncobj_func_t func)
9c19fb10a5893d Jason Ekstrand 2017-08-28  128  {
9c19fb10a5893d Jason Ekstrand 2017-08-28  129  	spin_lock(&syncobj->lock);
9c19fb10a5893d Jason Ekstrand 2017-08-28  130  	drm_syncobj_add_callback_locked(syncobj, cb, func);
9c19fb10a5893d Jason Ekstrand 2017-08-28  131  	spin_unlock(&syncobj->lock);
9c19fb10a5893d Jason Ekstrand 2017-08-28  132  }
9c19fb10a5893d Jason Ekstrand 2017-08-28  133  
9c19fb10a5893d Jason Ekstrand 2017-08-28 @134  void drm_syncobj_remove_callback(struct drm_syncobj *syncobj,
9c19fb10a5893d Jason Ekstrand 2017-08-28  135  				 struct drm_syncobj_cb *cb)
9c19fb10a5893d Jason Ekstrand 2017-08-28  136  {
9c19fb10a5893d Jason Ekstrand 2017-08-28  137  	spin_lock(&syncobj->lock);
9c19fb10a5893d Jason Ekstrand 2017-08-28  138  	list_del_init(&cb->node);
9c19fb10a5893d Jason Ekstrand 2017-08-28  139  	spin_unlock(&syncobj->lock);
9c19fb10a5893d Jason Ekstrand 2017-08-28  140  }
9c19fb10a5893d Jason Ekstrand 2017-08-28  141  

:::::: The code at line 125 was first introduced by commit
:::::: 9c19fb10a5893d6501df4d0fb93d954d5fc1d91b drm/syncobj: Add a callback mechanism for replace_fence (v3)

:::::: TO: Jason Ekstrand <jason@...kstrand.net>
:::::: CC: Dave Airlie <airlied@...hat.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp