linux-kernel - Re: [PATCH] memory: OMAP_GPMC should depend on ARCH_OMAP2PLUS || ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cec89ab-76f7-65d5-0b1d-fdd768234f0e@kernel.org>
Date:   Tue, 10 May 2022 11:10:38 +0300
From:   Roger Quadros <rogerq@...nel.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Tony Lindgren <tony@...mide.com>,
        "open list:TI ETHERNET SWITCH DRIVER (CPSW)" 
        <linux-omap@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] memory: OMAP_GPMC should depend on ARCH_OMAP2PLUS ||
 ARCH_K3

Geert,

On 10/05/2022 11:06, Geert Uytterhoeven wrote:
> Hi Roger,
> 
> On Tue, May 10, 2022 at 9:40 AM Roger Quadros <rogerq@...nel.org> wrote:
>> On 10/05/2022 10:30, Geert Uytterhoeven wrote:
>>> On Tue, May 10, 2022 at 9:22 AM Roger Quadros <rogerq@...nel.org> wrote:
>>>> On 09/05/2022 16:48, Geert Uytterhoeven wrote:
>>>>> The Texas Instruments OMAP General Purpose Memory Controller (GPMC) is
>>>>> only present on TI OMAP2/3/4/5, AM33xx, AM43x, DRA7xx, TI81xx, and K3
>>>>> SoCs.  Hence add a dependency on ARCH_OMAP2PLUS || ARCH_K3, to prevent
>>>>> asking the user about this driver when configuring a kernel without
>>>>> OMAP2+ or K3 SoC family support.
>>>>>
>>>>> Fixes: be34f45f0d4aa91c ("memory: omap-gpmc: Make OMAP_GPMC config visible and selectable")
>>>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
>> Could you please also add ARCH_KEYSTONE in the 'depends on' list
>> as some SoCs in that architecture do have the GPMC block.
> 
> Are you sure? AFAICS, none of the Keystone DTS files have device
> nodes that are compatible with the match list in the omap-gpmc driver.

Yes, the 66AK2G12 SoC contains the GPMC module. [1]

> 
> Or perhaps the GPMC support still has to be added to the Keystone
> DTS files (and or driver)?

That's most likely the case.

cheers,
-roger

[1] 66AK2G12 datasheet: https://www.ti.com/lit/ds/symlink/66ak2g12.pdf?ts=1652170122865&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252F66AK2G12