linux-kernel - Re: [PATCH -next] usb: dwc3: include extcon.h to fix compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 May 2022 10:28:42 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Guan Jing <guanjing6@...wei.com>
Cc:     balbi@...nel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] usb: dwc3: include extcon.h to fix compile error

On Tue, May 10, 2022 at 04:20:29PM +0800, Guan Jing wrote:
> If dwc3 is not include extcon.h, the dwc3 driver
> will fail to link:
> 
> drivers/usb/dwc3/core.o: In function `dwc3_probe':
> core.c:(.text+0x1095): undefined reference to `extcon_get_edev_by_phandle'
> core.c:(.text+0x10bd): undefined reference to `extcon_get_extcon_dev'
> 
> Add miss #include <linux/extcon.h> to fix this error.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Guan Jing <guanjing6@...wei.com>
> ---
>  drivers/usb/dwc3/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 950e238c65bf..ea7259443283 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -33,6 +33,7 @@
>  #include <linux/usb/gadget.h>
>  #include <linux/usb/of.h>
>  #include <linux/usb/otg.h>
> +#include <linux/extcon.h>
>  
>  #include "core.h"
>  #include "gadget.h"
> -- 
> 2.17.1
> 

Very odd, I do not see these build errors here.

What commit id does this change fix?  What caused the problem?

And please put the extcon.h include above the usb includes, as that's
the better place for it, right?

thanks,

greg k-h