| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 May 2022 16:54:10 +0800
From: kernel test robot <lkp@...el.com>
To: David Howells <dhowells@...hat.com>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:dhowells/linux-fs/cifs-for-sfrench 5/6]
fs/cifs/smb2pdu.c:4058:31: error: no member named 'pages' in 'struct
cifs_readdata'
tree: https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/cifs-for-sfrench
head: 627ce4da99bb612945366770c5604019fb74b653
commit: e4b60df6a12099568c671591d36a9fa16515f6eb [5/6] cifs: Change the I/O paths to use an iterator rather than a page list
config: i386-randconfig-r006-20220509 (https://download.01.org/0day-ci/archive/20220510/202205101619.kEs4YxeR-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 3abb68a626160e019c30a4860e569d7bc75e486a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/e4b60df6a12099568c671591d36a9fa16515f6eb
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block dhowells/linux-fs/cifs-for-sfrench
git checkout e4b60df6a12099568c671591d36a9fa16515f6eb
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
>> fs/cifs/smb2pdu.c:4058:31: error: no member named 'pages' in 'struct cifs_readdata'
server->smbd_conn, rdata->pages,
~~~~~ ^
>> fs/cifs/smb2pdu.c:4059:12: error: no member named 'nr_pages' in 'struct cifs_readdata'
rdata->nr_pages, rdata->page_offset,
~~~~~ ^
>> fs/cifs/smb2pdu.c:4059:29: error: no member named 'page_offset' in 'struct cifs_readdata'
rdata->nr_pages, rdata->page_offset,
~~~~~ ^
>> fs/cifs/smb2pdu.c:4060:12: error: no member named 'tailsz' in 'struct cifs_readdata'
rdata->tailsz, true, need_invalidate);
~~~~~ ^
>> fs/cifs/smb2pdu.c:4481:31: error: no member named 'pages' in 'struct cifs_writedata'
server->smbd_conn, wdata->pages,
~~~~~ ^
>> fs/cifs/smb2pdu.c:4482:12: error: no member named 'nr_pages' in 'struct cifs_writedata'
wdata->nr_pages, wdata->page_offset,
~~~~~ ^
>> fs/cifs/smb2pdu.c:4482:29: error: no member named 'page_offset' in 'struct cifs_writedata'
wdata->nr_pages, wdata->page_offset,
~~~~~ ^
>> fs/cifs/smb2pdu.c:4483:12: error: no member named 'tailsz' in 'struct cifs_writedata'
wdata->tailsz, false, need_invalidate);
~~~~~ ^
fs/cifs/smb2pdu.c:4490:14: error: no member named 'nr_pages' in 'struct cifs_writedata'
if (wdata->nr_pages > 1)
~~~~~ ^
include/linux/compiler.h:56:47: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^~~~
include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
fs/cifs/smb2pdu.c:4490:14: error: no member named 'nr_pages' in 'struct cifs_writedata'
if (wdata->nr_pages > 1)
~~~~~ ^
include/linux/compiler.h:56:47: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^~~~
include/linux/compiler.h:58:61: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
fs/cifs/smb2pdu.c:4490:14: error: no member named 'nr_pages' in 'struct cifs_writedata'
if (wdata->nr_pages > 1)
~~~~~ ^
include/linux/compiler.h:56:47: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^~~~
include/linux/compiler.h:58:86: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
include/linux/compiler.h:69:3: note: expanded from macro '__trace_if_value'
(cond) ? \
^~~~
fs/cifs/smb2pdu.c:4493:14: error: no member named 'nr_pages' in 'struct cifs_writedata'
(wdata->nr_pages - 1) * wdata->pagesz -
~~~~~ ^
include/linux/byteorder/generic.h:88:21: note: expanded from macro 'cpu_to_le32'
#define cpu_to_le32 __cpu_to_le32
^
include/uapi/linux/byteorder/little_endian.h:34:51: note: expanded from macro '__cpu_to_le32'
#define __cpu_to_le32(x) ((__force __le32)(__u32)(x))
^
>> fs/cifs/smb2pdu.c:4493:37: error: no member named 'pagesz' in 'struct cifs_writedata'
(wdata->nr_pages - 1) * wdata->pagesz -
~~~~~ ^
include/linux/byteorder/generic.h:88:21: note: expanded from macro 'cpu_to_le32'
#define cpu_to_le32 __cpu_to_le32
^
include/uapi/linux/byteorder/little_endian.h:34:51: note: expanded from macro '__cpu_to_le32'
#define __cpu_to_le32(x) ((__force __le32)(__u32)(x))
^
fs/cifs/smb2pdu.c:4494:13: error: no member named 'page_offset' in 'struct cifs_writedata'
wdata->page_offset + wdata->tailsz
~~~~~ ^
include/linux/byteorder/generic.h:88:21: note: expanded from macro 'cpu_to_le32'
#define cpu_to_le32 __cpu_to_le32
^
include/uapi/linux/byteorder/little_endian.h:34:51: note: expanded from macro '__cpu_to_le32'
#define __cpu_to_le32(x) ((__force __le32)(__u32)(x))
^
fs/cifs/smb2pdu.c:4494:34: error: no member named 'tailsz' in 'struct cifs_writedata'
wdata->page_offset + wdata->tailsz
~~~~~ ^
include/linux/byteorder/generic.h:88:21: note: expanded from macro 'cpu_to_le32'
#define cpu_to_le32 __cpu_to_le32
^
include/uapi/linux/byteorder/little_endian.h:34:51: note: expanded from macro '__cpu_to_le32'
#define __cpu_to_le32(x) ((__force __le32)(__u32)(x))
^
fs/cifs/smb2pdu.c:4497:45: error: no member named 'tailsz' in 'struct cifs_writedata'
req->RemainingBytes = cpu_to_le32(wdata->tailsz);
~~~~~ ^
include/linux/byteorder/generic.h:88:21: note: expanded from macro 'cpu_to_le32'
#define cpu_to_le32 __cpu_to_le32
^
include/uapi/linux/byteorder/little_endian.h:34:51: note: expanded from macro '__cpu_to_le32'
#define __cpu_to_le32(x) ((__force __le32)(__u32)(x))
^
>> fs/cifs/smb2pdu.c:4520:8: error: no member named 'rq_npages' in 'struct smb_rqst'
rqst.rq_npages = 0;
~~~~ ^
17 errors generated.
--
>> fs/cifs/smbdirect.c:2037:36: error: no member named 'rq_npages' in 'struct smb_rqst'
rqst_idx, rqst->rq_nvec, rqst->rq_npages, rqst->rq_pagesz,
~~~~ ^
fs/cifs/smbdirect.c:146:74: note: expanded from macro 'log_write'
#define log_write(level, fmt, args...) log_rdma(level, LOG_WRITE, fmt, ##args)
^~~~
fs/cifs/smbdirect.c:138:53: note: expanded from macro 'log_rdma'
cifs_dbg(VFS, "%s:%d " fmt, __func__, __LINE__, ##args);\
^~~~
fs/cifs/cifs_debug.h:140:19: note: expanded from macro 'cifs_dbg'
pr_debug(fmt, ##__VA_ARGS__); \
^~~~~~~~~~~
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
include/linux/dynamic_debug.h:163:22: note: expanded from macro 'dynamic_pr_debug'
pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:152:56: note: expanded from macro '_dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:134:15: note: expanded from macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
>> fs/cifs/smbdirect.c:2037:53: error: no member named 'rq_pagesz' in 'struct smb_rqst'
rqst_idx, rqst->rq_nvec, rqst->rq_npages, rqst->rq_pagesz,
~~~~ ^
fs/cifs/smbdirect.c:146:74: note: expanded from macro 'log_write'
#define log_write(level, fmt, args...) log_rdma(level, LOG_WRITE, fmt, ##args)
^~~~
fs/cifs/smbdirect.c:138:53: note: expanded from macro 'log_rdma'
cifs_dbg(VFS, "%s:%d " fmt, __func__, __LINE__, ##args);\
^~~~
fs/cifs/cifs_debug.h:140:19: note: expanded from macro 'cifs_dbg'
pr_debug(fmt, ##__VA_ARGS__); \
^~~~~~~~~~~
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
include/linux/dynamic_debug.h:163:22: note: expanded from macro 'dynamic_pr_debug'
pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:152:56: note: expanded from macro '_dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:134:15: note: expanded from macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
>> fs/cifs/smbdirect.c:2038:11: error: no member named 'rq_tailsz' in 'struct smb_rqst'
rqst->rq_tailsz, smb_rqst_len(server, rqst));
~~~~ ^
fs/cifs/smbdirect.c:146:74: note: expanded from macro 'log_write'
#define log_write(level, fmt, args...) log_rdma(level, LOG_WRITE, fmt, ##args)
^~~~
fs/cifs/smbdirect.c:138:53: note: expanded from macro 'log_rdma'
cifs_dbg(VFS, "%s:%d " fmt, __func__, __LINE__, ##args);\
^~~~
fs/cifs/cifs_debug.h:140:19: note: expanded from macro 'cifs_dbg'
pr_debug(fmt, ##__VA_ARGS__); \
^~~~~~~~~~~
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
include/linux/dynamic_debug.h:163:22: note: expanded from macro 'dynamic_pr_debug'
pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:152:56: note: expanded from macro '_dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:134:15: note: expanded from macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
fs/cifs/smbdirect.c:2107:24: error: no member named 'rq_npages' in 'struct smb_rqst'
for (i = 0; i < rqst->rq_npages; i++) {
~~~~ ^
>> fs/cifs/smbdirect.c:2110:3: error: call to undeclared function 'rqst_page_get_length'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
rqst_page_get_length(rqst, i, &buflen, &offset);
^
>> fs/cifs/smbdirect.c:2123:17: error: no member named 'rq_pages' in 'struct smb_rqst'
info, rqst->rq_pages[i],
~~~~ ^
6 errors generated.
vim +4058 fs/cifs/smb2pdu.c
09a4707e763824 Pavel Shilovsky 2012-09-18 4007
09a4707e763824 Pavel Shilovsky 2012-09-18 4008 /*
09a4707e763824 Pavel Shilovsky 2012-09-18 4009 * To form a chain of read requests, any read requests after the first should
09a4707e763824 Pavel Shilovsky 2012-09-18 4010 * have the end_of_chain boolean set to true.
09a4707e763824 Pavel Shilovsky 2012-09-18 4011 */
09a4707e763824 Pavel Shilovsky 2012-09-18 4012 static int
738f9de5cdb917 Pavel Shilovsky 2016-11-23 4013 smb2_new_read_req(void **buf, unsigned int *total_len,
2dabfd5baba641 Long Li 2017-11-07 4014 struct cifs_io_parms *io_parms, struct cifs_readdata *rdata,
2dabfd5baba641 Long Li 2017-11-07 4015 unsigned int remaining_bytes, int request_type)
09a4707e763824 Pavel Shilovsky 2012-09-18 4016 {
09a4707e763824 Pavel Shilovsky 2012-09-18 4017 int rc = -EACCES;
d8d9de532de9fa Ronnie Sahlberg 2021-09-08 4018 struct smb2_read_req *req = NULL;
0d35e382e4e96a Ronnie Sahlberg 2021-11-05 4019 struct smb2_hdr *shdr;
352d96f3acc6e0 Aurelien Aptel 2020-05-31 4020 struct TCP_Server_Info *server = io_parms->server;
09a4707e763824 Pavel Shilovsky 2012-09-18 4021
352d96f3acc6e0 Aurelien Aptel 2020-05-31 4022 rc = smb2_plain_req_init(SMB2_READ, io_parms->tcon, server,
352d96f3acc6e0 Aurelien Aptel 2020-05-31 4023 (void **) &req, total_len);
09a4707e763824 Pavel Shilovsky 2012-09-18 4024 if (rc)
09a4707e763824 Pavel Shilovsky 2012-09-18 4025 return rc;
2dabfd5baba641 Long Li 2017-11-07 4026
2dabfd5baba641 Long Li 2017-11-07 4027 if (server == NULL)
09a4707e763824 Pavel Shilovsky 2012-09-18 4028 return -ECONNABORTED;
09a4707e763824 Pavel Shilovsky 2012-09-18 4029
0d35e382e4e96a Ronnie Sahlberg 2021-11-05 4030 shdr = &req->hdr;
0d35e382e4e96a Ronnie Sahlberg 2021-11-05 4031 shdr->Id.SyncId.ProcessId = cpu_to_le32(io_parms->pid);
09a4707e763824 Pavel Shilovsky 2012-09-18 4032
351a59dace0e0e Paulo Alcantara 2022-03-21 4033 req->PersistentFileId = io_parms->persistent_fid;
351a59dace0e0e Paulo Alcantara 2022-03-21 4034 req->VolatileFileId = io_parms->volatile_fid;
09a4707e763824 Pavel Shilovsky 2012-09-18 4035 req->ReadChannelInfoOffset = 0; /* reserved */
09a4707e763824 Pavel Shilovsky 2012-09-18 4036 req->ReadChannelInfoLength = 0; /* reserved */
09a4707e763824 Pavel Shilovsky 2012-09-18 4037 req->Channel = 0; /* reserved */
09a4707e763824 Pavel Shilovsky 2012-09-18 4038 req->MinimumCount = 0;
09a4707e763824 Pavel Shilovsky 2012-09-18 4039 req->Length = cpu_to_le32(io_parms->length);
09a4707e763824 Pavel Shilovsky 2012-09-18 4040 req->Offset = cpu_to_le64(io_parms->offset);
d323c24617527f Steve French 2019-02-25 4041
d323c24617527f Steve French 2019-02-25 4042 trace_smb3_read_enter(0 /* xid */,
d323c24617527f Steve French 2019-02-25 4043 io_parms->persistent_fid,
d323c24617527f Steve French 2019-02-25 4044 io_parms->tcon->tid, io_parms->tcon->ses->Suid,
d323c24617527f Steve French 2019-02-25 4045 io_parms->offset, io_parms->length);
bd3dcc6a22a918 Long Li 2017-11-22 4046 #ifdef CONFIG_CIFS_SMB_DIRECT
bd3dcc6a22a918 Long Li 2017-11-22 4047 /*
bd3dcc6a22a918 Long Li 2017-11-22 4048 * If we want to do a RDMA write, fill in and append
bd3dcc6a22a918 Long Li 2017-11-22 4049 * smbd_buffer_descriptor_v1 to the end of read request
bd3dcc6a22a918 Long Li 2017-11-22 4050 */
bb4c0419476bd3 Long Li 2018-04-17 4051 if (server->rdma && rdata && !server->sign &&
bd3dcc6a22a918 Long Li 2017-11-22 4052 rdata->bytes >= server->smbd_conn->rdma_readwrite_threshold) {
bd3dcc6a22a918 Long Li 2017-11-22 4053
bd3dcc6a22a918 Long Li 2017-11-22 4054 struct smbd_buffer_descriptor_v1 *v1;
352d96f3acc6e0 Aurelien Aptel 2020-05-31 4055 bool need_invalidate = server->dialect == SMB30_PROT_ID;
bd3dcc6a22a918 Long Li 2017-11-22 4056
bd3dcc6a22a918 Long Li 2017-11-22 4057 rdata->mr = smbd_register_mr(
bd3dcc6a22a918 Long Li 2017-11-22 @4058 server->smbd_conn, rdata->pages,
7cf20bce77581b Long Li 2018-05-30 @4059 rdata->nr_pages, rdata->page_offset,
7cf20bce77581b Long Li 2018-05-30 @4060 rdata->tailsz, true, need_invalidate);
bd3dcc6a22a918 Long Li 2017-11-22 4061 if (!rdata->mr)
b7972092199f6d Long Li 2019-04-05 4062 return -EAGAIN;
bd3dcc6a22a918 Long Li 2017-11-22 4063
bd3dcc6a22a918 Long Li 2017-11-22 4064 req->Channel = SMB2_CHANNEL_RDMA_V1_INVALIDATE;
bd3dcc6a22a918 Long Li 2017-11-22 4065 if (need_invalidate)
bd3dcc6a22a918 Long Li 2017-11-22 4066 req->Channel = SMB2_CHANNEL_RDMA_V1;
bd3dcc6a22a918 Long Li 2017-11-22 4067 req->ReadChannelInfoOffset =
d8d9de532de9fa Ronnie Sahlberg 2021-09-08 4068 cpu_to_le16(offsetof(struct smb2_read_req, Buffer));
bd3dcc6a22a918 Long Li 2017-11-22 4069 req->ReadChannelInfoLength =
2026b06e9ce852 Steve French 2018-01-24 4070 cpu_to_le16(sizeof(struct smbd_buffer_descriptor_v1));
bd3dcc6a22a918 Long Li 2017-11-22 4071 v1 = (struct smbd_buffer_descriptor_v1 *) &req->Buffer[0];
2026b06e9ce852 Steve French 2018-01-24 4072 v1->offset = cpu_to_le64(rdata->mr->mr->iova);
2026b06e9ce852 Steve French 2018-01-24 4073 v1->token = cpu_to_le32(rdata->mr->mr->rkey);
2026b06e9ce852 Steve French 2018-01-24 4074 v1->length = cpu_to_le32(rdata->mr->mr->length);
bd3dcc6a22a918 Long Li 2017-11-22 4075
bd3dcc6a22a918 Long Li 2017-11-22 4076 *total_len += sizeof(*v1) - 1;
bd3dcc6a22a918 Long Li 2017-11-22 4077 }
bd3dcc6a22a918 Long Li 2017-11-22 4078 #endif
09a4707e763824 Pavel Shilovsky 2012-09-18 4079 if (request_type & CHAINED_REQUEST) {
09a4707e763824 Pavel Shilovsky 2012-09-18 4080 if (!(request_type & END_OF_CHAIN)) {
b8f57ee8aad414 Pavel Shilovsky 2016-11-23 4081 /* next 8-byte aligned request */
b8f57ee8aad414 Pavel Shilovsky 2016-11-23 4082 *total_len = DIV_ROUND_UP(*total_len, 8) * 8;
b8f57ee8aad414 Pavel Shilovsky 2016-11-23 4083 shdr->NextCommand = cpu_to_le32(*total_len);
09a4707e763824 Pavel Shilovsky 2012-09-18 4084 } else /* END_OF_CHAIN */
31473fc4f9653b Pavel Shilovsky 2016-10-24 4085 shdr->NextCommand = 0;
09a4707e763824 Pavel Shilovsky 2012-09-18 4086 if (request_type & RELATED_REQUEST) {
31473fc4f9653b Pavel Shilovsky 2016-10-24 4087 shdr->Flags |= SMB2_FLAGS_RELATED_OPERATIONS;
09a4707e763824 Pavel Shilovsky 2012-09-18 4088 /*
09a4707e763824 Pavel Shilovsky 2012-09-18 4089 * Related requests use info from previous read request
09a4707e763824 Pavel Shilovsky 2012-09-18 4090 * in chain.
09a4707e763824 Pavel Shilovsky 2012-09-18 4091 */
0d35e382e4e96a Ronnie Sahlberg 2021-11-05 4092 shdr->SessionId = cpu_to_le64(0xFFFFFFFFFFFFFFFF);
0d35e382e4e96a Ronnie Sahlberg 2021-11-05 4093 shdr->Id.SyncId.TreeId = cpu_to_le32(0xFFFFFFFF);
351a59dace0e0e Paulo Alcantara 2022-03-21 4094 req->PersistentFileId = (u64)-1;
351a59dace0e0e Paulo Alcantara 2022-03-21 4095 req->VolatileFileId = (u64)-1;
09a4707e763824 Pavel Shilovsky 2012-09-18 4096 }
09a4707e763824 Pavel Shilovsky 2012-09-18 4097 }
09a4707e763824 Pavel Shilovsky 2012-09-18 4098 if (remaining_bytes > io_parms->length)
09a4707e763824 Pavel Shilovsky 2012-09-18 4099 req->RemainingBytes = cpu_to_le32(remaining_bytes);
09a4707e763824 Pavel Shilovsky 2012-09-18 4100 else
09a4707e763824 Pavel Shilovsky 2012-09-18 4101 req->RemainingBytes = 0;
09a4707e763824 Pavel Shilovsky 2012-09-18 4102
738f9de5cdb917 Pavel Shilovsky 2016-11-23 4103 *buf = req;
09a4707e763824 Pavel Shilovsky 2012-09-18 4104 return rc;
09a4707e763824 Pavel Shilovsky 2012-09-18 4105 }
09a4707e763824 Pavel Shilovsky 2012-09-18 4106
:::::: The code at line 4058 was first introduced by commit
:::::: bd3dcc6a22a9186ed78da51ce09e889803552189 CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration
:::::: TO: Long Li <longli@...rosoft.com>
:::::: CC: Steve French <smfrench@...il.com>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists