linux-kernel - Re: [PATCH] gpio: gpio-vf610: do not touch other bits when set the target bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b18b894-8f81-8865-06c4-d112aaa85c8b@oss.nxp.com>
Date:   Tue, 10 May 2022 17:02:27 +0800
From:   "Peng Fan (OSS)" <peng.fan@....nxp.com>
To:     haibo.chen@....com, linus.walleij@...aro.org, brgl@...ev.pl
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-imx@....com
Subject: Re: [PATCH] gpio: gpio-vf610: do not touch other bits when set the
 target bit



On 2022/5/7 18:54, haibo.chen@....com wrote:
> From: Haibo Chen <haibo.chen@....com>
> 
> For gpio controller contain register PDDR, when set one target bit,
> current logic will clear all other bits, this is wrong. Use operator
> '|=' to fix it.
> 

A fixes tag required, since this is a fix. With fixes tag added:
Reviewed-by: Peng Fan <peng.fan@....com>

Regards,
Peng.

> Signed-off-by: Haibo Chen <haibo.chen@....com>
> ---
>   drivers/gpio/gpio-vf610.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
> index 20780c35da1b..23cddb265a0d 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -125,9 +125,13 @@ static int vf610_gpio_direction_output(struct gpio_chip *chip, unsigned gpio,
>   {
>   	struct vf610_gpio_port *port = gpiochip_get_data(chip);
>   	unsigned long mask = BIT(gpio);
> +	u32 val;
>   
> -	if (port->sdata && port->sdata->have_paddr)
> -		vf610_gpio_writel(mask, port->gpio_base + GPIO_PDDR);
> +	if (port->sdata && port->sdata->have_paddr) {
> +		val = vf610_gpio_readl(port->gpio_base + GPIO_PDDR);
> +		val |= mask;
> +		vf610_gpio_writel(val, port->gpio_base + GPIO_PDDR);
> +	}
>   
>   	vf610_gpio_set(chip, gpio, value);
>   
>