linux-kernel - Re: [PATCH v2] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49566544-e8f2-ef38-288e-fcd276d87d3b@vivo.com>
Date:   Tue, 10 May 2022 17:23:49 +0800
From:   Jiabing Wan <wanjiabing@...o.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Rex-BC Chen <rex-bc.chen@...iatek.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Jia-Wei Chang <jia-wei.chang@...iatek.com>,
        "Andrew-sh.Cheng" <andrew-sh.cheng@...iatek.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2] cpufreq: mediatek: Fix potential deadlock problem in
 mtk_cpufreq_set_target



On 2022/5/10 17:12, Viresh Kumar wrote:
> On 10-05-22, 17:05, Wan Jiabing wrote:
>> Fix following coccichek error:
>> ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
>> ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
>>
>> mutex_lock is acquired but not released before return.
>> Use 'goto out' to help releasing the mutex_lock.
>>
>> Fixes: c210063b40ac ("cpufreq: mediatek: Add opp notification support")
>> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> You should have added the review tag you received.
>
> Applied. Thanks.

Oh, yes.  I would add the "Reviewed-by:" tag only if someone sends
this tag to me.

Like:
[0] https://lore.kernel.org/all/YnkvM5iuSuAOqBg+@lunn.ch/
[1] 
https://lore.kernel.org/all/20220510015521.2542096-1-wanjiabing@vivo.com/

If not explicitly stated, I am afraid to add some wrong "Reviewed-by:"
tags which might bother maintainers.

Thanks a lot for your priceless advice!

Wan Jiabing