linux-kernel - Re: Question about SC16IS752 device tree.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 May 2022 10:29:57 +0800
From:   Zhou Yanjie <zhouyanjie@...yeetech.com>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Paul Cercueil <paul@...pouillou.net>, jringle@...dpoint.com,
        shc_work@...l.ru, Rob Herring <robh@...nel.org>,
        Paul Boddie <paul@...die.org.uk>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        linux-serial@...r.kernel.org,
        linux-mips <linux-mips@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Question about SC16IS752 device tree.

Hi Nikolaus,

On 2022/5/10 上午4:19, H. Nikolaus Schaller wrote:
> Hi,
>
>> Am 09.05.2022 um 20:41 schrieb Zhou Yanjie <zhouyanjie@...yeetech.com>:
>>
>> Hi Paul,
>>
>> On 2022/5/10 上午2:13, Paul Cercueil wrote:
>>> I can't say for sure that it's your problem, but your bluetooth nodes are missing "reg" properties.
>>
>> Unfortunately it doesn't seem to be the problem here, I added "reg" and
>> the problem persists, and I've looked at other device trees that contain
>> "brcm,bcm43438-bt", none of them use "reg", and "reg" is not mentioned in
>> neither "Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt" nor
>> "Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml".
> what happens if you remove the serdev children from DTS? Does the driver create two separate /dev/tty ports? And do they work?


Yes, there will be two separate /dev/tty ports (ttySC0 and ttySC1), and
both ports can work normally, but at this time the two bluetooth modules
are not working.

I guess it is because the driver does not detect bluetooth module nodes,
so the inability to operate "reset-gpios" and "device-wakeup-gpios" causes
the bluetooth module to work incorrectly.


>
> Maybe the sc16is752 driver does not separate them for child nodes, i.e. while "reg" should be added it may not be handled?


I'm not too sure, I'm not very familiar with serial port systems.
If the truth is what you think, how should I improve it?


Best regards!


>
> BR,
> Nikolaus