linux-kernel - Re: [PATCH v6 1/3] dt-bindings: marvell: Document the AC5/AC5X compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YnvsInrh03BVh7lN@lunn.ch>
Date:   Wed, 11 May 2022 19:02:26 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        catalin.marinas@....com, will@...nel.org,
        gregory.clement@...tlin.com, sebastian.hesselbarth@...il.com,
        kostap@...vell.com, robert.marko@...tura.hr,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 1/3] dt-bindings: marvell: Document the AC5/AC5X
 compatibles

On Wed, May 11, 2022 at 11:10:00AM +1200, Chris Packham wrote:
> Describe the compatible properties for the Marvell Alleycat5/5X switches
> with integrated CPUs.
> 
> Alleycat5:
> * 98DX2538: 24x1G + 2x10G + 2x10G Stack
> * 98DX2535: 24x1G + 4x1G Stack
> * 98DX2532: 8x1G + 2x10G + 2x1G Stack
> * 98DX2531: 8x1G + 4x1G Stack
> * 98DX2528: 24x1G + 2x10G + 2x10G Stack
> * 98DX2525: 24x1G + 4x1G Stack
> * 98DX2522: 8x1G + 2x10G + 2x1G Stack
> * 98DX2521: 8x1G + 4x1G Stack
> * 98DX2518: 24x1G + 2x10G + 2x10G Stack
> * 98DX2515: 24x1G + 4x1G Stack
> * 98DX2512: 8x1G + 2x10G + 2x1G Stack
> * 98DX2511: 8x1G + 4x1G Stack
> 
> Alleycat5X:
> * 98DX3500: 24x1G + 6x25G
> * 98DX3501: 16x1G + 6x10G
> * 98DX3510: 48x1G + 6x25G
> * 98DX3520: 24x2.5G + 6x25G
> * 98DX3530: 48x2.5G + 6x25G
> * 98DX3540: 12x5G/6x10G + 6x25G
> * 98DX3550: 24x5G/12x10G + 6x25G

Hi Chris

When looking at this list, is it just the switch which changes, and
everything else in the package stays the same?

I'm thinking back to plain Kirkwood. There were 3 Kirkwood SoCs. We
had kirkwood.dtsi which described everything common to all three
SoCs. And then kirkwood-6192.dtsi, kirkwood-6281.dtsi,
kirkwood-6282.dtsi which extended that base with whatever additional
things each SoC had.

I'm wondering if something similar is needed here?

armada-98DX25xx.dtsi which describes everything common to Alleycat5.

armada-98DX35xx.dtsi which describes everything common to Alleycat5X,
maybe making use of armada-98DX25xx.dtsi?.

armada-98DX2538.dtsi which extends armada-98DX25xx.dtsi

And then a board file which includes armada-98DX2538.dtsi and add the
board specific bits?

I've no idea how these different devices differ, so i don't know what
the correct hierarchy should be.

    Andrew