linux-kernel - Re: [PATCH v1] PM: EM: Decrement policy counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0i0BTOFZ8Rhh_da5_mgZQW0+qCoeiDpWLwVJfJwjgYAqg@mail.gmail.com>
Date:   Wed, 11 May 2022 19:17:21 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Vincent Donnefort <vincent.donnefort@....com>,
        Pierre Gondois <pierre.gondois@....com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Cristian Marussi <cristian.marussi@....com>,
        Ionela Voinescu <Ionela.Voinescu@....com>,
        Dietmar Eggemann <Dietmar.Eggemann@....com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v1] PM: EM: Decrement policy counter

On Tue, Apr 26, 2022 at 5:40 PM Vincent Donnefort
<vincent.donnefort@....com> wrote:
>
> On 26/04/2022 15:44, Pierre Gondois wrote:
> > From: Pierre Gondois <Pierre.Gondois@....com>
> >
> > Fixes: e458716a92b57 ("PM: EM: Mark inefficiencies in CPUFreq")
> > In the above commit, cpufreq_cpu_get() is called without
> > a cpufreq_cpu_put(), permanently increasing the reference counts
> > of the policy struct.
> > Decrement the reference count once the policy struct is not used
> > anymore.
>
>
> Not sure if the tag there will be caught properly. Usually it goes on
> top of the Signed-off-by.
>
> While at it:
>
> Reviewed-by: Vincent Donnefort <vincent.donnefort@....com>
>
> Thanks for fixing this.

Applied as 5.19 material, thanks!