linux-kernel - Re: [PATCH v2 5/5] clang-format: Fix space after for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8400e5da994b81dda0b90c840afb92489ca0061.camel@perches.com>
Date:   Wed, 11 May 2022 10:38:50 -0700
From:   Joe Perches <joe@...ches.com>
To:     Mickaël Salaün <mic@...ikod.net>,
        Miguel Ojeda <ojeda@...nel.org>
Cc:     Andy Whitcroft <apw@...onical.com>,
        Brian Norris <briannorris@...omium.org>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        "Jason A . Donenfeld" <Jason@...c4.com>,
        Kees Cook <keescook@...omium.org>,
        Konstantin Meskhidze <konstantin.meskhidze@...wei.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Paul Moore <paul@...l-moore.com>, Tom Rix <trix@...hat.com>,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH v2 5/5] clang-format: Fix space after for_each macros

On Wed, 2022-05-11 at 19:34 +0200, Mickaël Salaün wrote:
> On 11/05/2022 17:40, Joe Perches wrote:
> > On Fri, 2022-05-06 at 18:01 +0200, Mickaël Salaün wrote:
> > > Set SpaceBeforeParens to ControlStatementsExceptForEachMacros to not add
> > > space between a for_each macro and the following parenthesis.  This
> > > option is available since clang-format-11 [1] and is in line with the
> > > checkpatch.pl rules [2].
> > 
> > If this is applied, could the .clang_format ForEachMacros:
> > block be removed?
> 
> The ForEachMacros block is still required to not put the " {" on the 
> next line.

Pity these aren't linked as many for_each macro definitions and uses
exist outside of the grep search paths.