linux-kernel - Re: [PATCH V5 00/31] x86/sgx and selftests/sgx: Support SGX2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 11 May 2022 11:47:31 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Jarkko Sakkinen <jarkko@...nel.org>
CC:     <dave.hansen@...ux.intel.com>, <tglx@...utronix.de>,
        <bp@...en8.de>, <luto@...nel.org>, <mingo@...hat.com>,
        <linux-sgx@...r.kernel.org>, <x86@...nel.org>, <shuah@...nel.org>,
        <linux-kselftest@...r.kernel.org>, <seanjc@...gle.com>,
        <kai.huang@...el.com>, <cathy.zhang@...el.com>,
        <cedric.xing@...el.com>, <haitao.huang@...el.com>,
        <mark.shanahan@...el.com>, <vijay.dhanraj@...el.com>,
        <hpa@...or.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V5 00/31] x86/sgx and selftests/sgx: Support SGX2

Hi Jarkko,

On 5/10/2022 3:22 PM, Jarkko Sakkinen wrote:
> If there is any patch that does not have my reviewed-by, please put it
> there. I was totally happy with v4 already. I went through these, and
> did not see anything worth of complaining about.
> 
> Great job, thank you for doing this.
> 
> I can also add my tag separely to each patch, which have not have it on
> request if that makes things easier in any possible way on request.

Thank you very much. I do appreciate all the feedback and testing.

All patches in this series have some tag from you, a few have "Acked-by"
instead of "Reviewed-by".

Patch 20/31 "x86/sgx: Free up EPC pages directly to support large
page ranges" is the only x86/sgx patch that has an "Acked-by" from you
instead of a "Reviewed-by". All selftests/sgx patches have an "Acked-by"
from you.

Here is a summary of your tags if you would like to make changes:

[PATCH V5 01/31] x86/sgx: Add short descriptions to ENCLS wrappers
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 02/31] x86/sgx: Add wrapper for SGX2 EMODPR function
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 03/31] x86/sgx: Add wrapper for SGX2 EMODT function
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 04/31] x86/sgx: Add wrapper for SGX2 EAUG function
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 05/31] x86/sgx: Support loading enclave page without VMA
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 06/31] x86/sgx: Export sgx_encl_ewb_cpumask()
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 07/31] x86/sgx: Rename sgx_encl_ewb_cpumask() as sgx_encl_cpumask()
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 08/31] x86/sgx: Move PTE zap code to new sgx_zap_enclave_ptes()
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 09/31] x86/sgx: Make sgx_ipi_cb() available internally
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 10/31] x86/sgx: Create utility to validate user provided offset and length
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 11/31] x86/sgx: Keep record of SGX page type
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 12/31] x86/sgx: Export sgx_encl_{grow,shrink}()
	Suggested-by: Jarkko Sakkinen <jarkko@...nel.org>
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 13/31] x86/sgx: Export sgx_encl_page_alloc()
	Signed-off-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 14/31] x86/sgx: Support VA page allocation without reclaiming
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 15/31] x86/sgx: Support restricting of enclave page permissions
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
	Tested-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 16/31] x86/sgx: Support adding of pages to an initialized enclave
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
	Tested-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 17/31] x86/sgx: Tighten accessible memory range after enclave initialization
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 18/31] x86/sgx: Support modifying SGX page type
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
	Tested-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 19/31] x86/sgx: Support complete page removal
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
	Tested-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 20/31] x86/sgx: Free up EPC pages directly to support large page ranges
	Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 21/31] Documentation/x86: Introduce enclave runtime management section
	Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 22/31] selftests/sgx: Add test for EPCM permission changes
	Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 23/31] selftests/sgx: Add test for TCS page permission changes
	Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 24/31] selftests/sgx: Test two different SGX2 EAUG flows
	Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 25/31] selftests/sgx: Introduce dynamic entry point
	Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 26/31] selftests/sgx: Introduce TCS initialization enclave operation
	Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 27/31] selftests/sgx: Test complete changing of page type flow
	Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 28/31] selftests/sgx: Test faulty enclave behavior
	Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 29/31] selftests/sgx: Test invalid access to removed enclave page
	Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 30/31] selftests/sgx: Test reclaiming of untouched page
	Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

[PATCH V5 31/31] selftests/sgx: Page removal stress test
	Acked-by: Jarkko Sakkinen <jarkko@...nel.org>	


Reinette