linux-kernel - [krzk-github:n/qcom-ufs-opp-v3 30/31] drivers/scsi/ufs/ufshcd.c:1056: warning: expecting prototype for Returns 0 for success, non(). Prototype was for ufshcd_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202205120226.P786kaQa-lkp@intel.com>
Date:   Thu, 12 May 2022 02:50:55 +0800
From:   kernel test robot <lkp@...el.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [krzk-github:n/qcom-ufs-opp-v3 30/31]
 drivers/scsi/ufs/ufshcd.c:1056: warning: expecting prototype for Returns 0
 for success, non(). Prototype was for ufshcd_set_opp() instead

tree:   https://github.com/krzk/linux n/qcom-ufs-opp-v3
head:   a37fb33a00889e90edd1c74de967b3315980a65d
commit: 83f52b94e7d208a3d1570fb3e8d6684186ac996f [30/31] ifss
config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20220512/202205120226.P786kaQa-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/krzk/linux/commit/83f52b94e7d208a3d1570fb3e8d6684186ac996f
        git remote add krzk-github https://github.com/krzk/linux
        git fetch --no-tags krzk-github n/qcom-ufs-opp-v3
        git checkout 83f52b94e7d208a3d1570fb3e8d6684186ac996f
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/scsi/ufs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/scsi/ufs/ufshcd.c:1039: warning: cannot understand function prototype: '/* static int ufshcd_set_clk_freq(struct ufs_hba *hba, unsigned long freq) '
   drivers/scsi/ufs/ufshcd.c:1056: warning: Function parameter or member 'data' not described in 'ufshcd_set_opp'
>> drivers/scsi/ufs/ufshcd.c:1056: warning: expecting prototype for Returns 0 for success, non(). Prototype was for ufshcd_set_opp() instead


vim +1056 drivers/scsi/ufs/ufshcd.c

868147b0e847f5 Krzysztof Kozlowski 2022-05-11  1051  
868147b0e847f5 Krzysztof Kozlowski 2022-05-11  1052  /**
868147b0e847f5 Krzysztof Kozlowski 2022-05-11  1053   * Returns 0 for success, non-zero error value for errors.
868147b0e847f5 Krzysztof Kozlowski 2022-05-11  1054   */
868147b0e847f5 Krzysztof Kozlowski 2022-05-11  1055  int ufshcd_set_opp(struct dev_pm_set_opp_data *data)
868147b0e847f5 Krzysztof Kozlowski 2022-05-11 @1056  {
e9b0ff4416ed23 Krzysztof Kozlowski 2022-05-11  1057  	struct ufs_hba *hba = dev_get_drvdata(data->dev);
e9b0ff4416ed23 Krzysztof Kozlowski 2022-05-11  1058  	unsigned long old_freq = data->old_opp.rate;
e9b0ff4416ed23 Krzysztof Kozlowski 2022-05-11  1059  	unsigned long freq = data->new_opp.rate;
e9b0ff4416ed23 Krzysztof Kozlowski 2022-05-11  1060  	bool scale_up;
868147b0e847f5 Krzysztof Kozlowski 2022-05-11  1061  
e9b0ff4416ed23 Krzysztof Kozlowski 2022-05-11  1062  	scale_up = (freq > old_freq);
e9b0ff4416ed23 Krzysztof Kozlowski 2022-05-11  1063  
e9b0ff4416ed23 Krzysztof Kozlowski 2022-05-11  1064  	pr_err("AAAA ufs %s %s %lu->%lu\n", __func__,
e9b0ff4416ed23 Krzysztof Kozlowski 2022-05-11  1065  	       (scale_up ? "up" : "down"),
e9b0ff4416ed23 Krzysztof Kozlowski 2022-05-11  1066  	       old_freq, freq);
e9b0ff4416ed23 Krzysztof Kozlowski 2022-05-11  1067  
e9b0ff4416ed23 Krzysztof Kozlowski 2022-05-11  1068  	return ufshcd_set_clk_freq_direct(hba, scale_up);
868147b0e847f5 Krzysztof Kozlowski 2022-05-11  1069  }
868147b0e847f5 Krzysztof Kozlowski 2022-05-11  1070  EXPORT_SYMBOL_GPL(ufshcd_set_opp);
868147b0e847f5 Krzysztof Kozlowski 2022-05-11  1071  

:::::: The code at line 1056 was first introduced by commit
:::::: 868147b0e847f596b8fff395a553c423f32ab7db wip

:::::: TO: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
:::::: CC: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp