linux-kernel - Re: [PATCH v2] drivers: gpio: zevio: drop of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 May 2022 23:34:06 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Moses Christopher Bollavarapu <mosescb.dev@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drivers: gpio: zevio: drop of_gpio.h header

On Wed, May 11, 2022 at 11:00 PM Moses Christopher Bollavarapu
<mosescb.dev@...il.com> wrote:
>
> Remove of_gpio.h header file, replace of_* functions and structs
> with appropriate alternatives.

...

>  V1 -> V2: Move gpio_chip member to top of the struct
>            Use dev_error_probe instead of dev_err
>            Minor style fixes

Almost, see below.

...

> +       controller->regs = devm_platform_ioremap_resource(pdev, 0);
> +       if (IS_ERR(controller->regs))
> +               dev_err_probe(&pdev->dev, PTR_ERR(controller->regs),
> +                             "failed to ioremap memory resource\n");

You forgot 'return'.

-- 
With Best Regards,
Andy Shevchenko