linux-kernel - Re: [PATCH net] net: bcmgenet: Check for Wake-on-LAN interrupt probe deferral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <720006e7-be4a-8878-7c2c-5b55f3e933f4@i2se.com>
Date:   Wed, 11 May 2022 08:01:58 +0200
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Cc:     Doug Berger <opendmb@...il.com>,
        Broadcom Kernel Team <bcm-kernel-feedback-list@...adcom.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: bcmgenet: Check for Wake-on-LAN interrupt probe
 deferral

Am 11.05.22 um 05:17 schrieb Florian Fainelli:
> The interrupt controller supplying the Wake-on-LAN interrupt line maybe
> modular on some platforms (irq-bcm7038-l1.c) and might be probed at a
> later time than the GENET driver. We need to specifically check for
> -EPROBE_DEFER and propagate that error to ensure that we eventually
> fetch the interrupt descriptor.
>
> Fixes: 9deb48b53e7f ("bcmgenet: add WOL IRQ check")
> Fixes: 5b1f0e62941b ("net: bcmgenet: Avoid touching non-existent interrupt")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
Reviewed-by: Stefan Wahren <stefan.wahren@...e.com>
> ---
>   drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index bf1ec8fdc2ad..e87e46c47387 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -3999,6 +3999,10 @@ static int bcmgenet_probe(struct platform_device *pdev)
>   		goto err;
>   	}
>   	priv->wol_irq = platform_get_irq_optional(pdev, 2);
> +	if (priv->wol_irq == -EPROBE_DEFER) {
> +		err = priv->wol_irq;
> +		goto err;
> +	}
>   
>   	priv->base = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(priv->base)) {