[<prev] [next>] [day] [month] [year] [list]
Message-ID: <CACD3sJa2qdocMXX3QFj5OdjFGd95M5nArJqPpEMjCYmb2ZvgHA@mail.gmail.com>
Date: Wed, 11 May 2022 08:28:40 +0800
From: Tyrone Ting <warp5tw@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
avifishman70@...il.com, Tomer Maimon <tmaimon77@...il.com>,
Tali Perry <tali.perry1@...il.com>,
Patrick Venture <venture@...gle.com>,
Nancy Yuen <yuenn@...gle.com>,
Benjamin Fair <benjaminfair@...gle.com>, robh+dt@...nel.org,
Wolfram Sang <wsa@...nel.org>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
jarkko.nikula@...ux.intel.com, semen.protsenko@...aro.org,
sven@...npeter.dev, jsd@...ihalf.com, lukas.bulwahn@...il.com,
olof@...om.net, arnd@...db.de, Tyrone Ting <warp5tw@...il.com>,
tali.perry@...oton.com, Avi.Fishman@...oton.com,
tomer.maimon@...oton.com, KWLIU@...oton.com, JJLIU0@...oton.com,
kfting <kfting@...oton.com>
Cc: openbmc@...ts.ozlabs.org, linux-i2c@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845
Tyrone Ting <warp5tw@...il.com> 於 2022年5月11日 週三 上午8:25寫道:
>
> Hi Krzysztof:
>
> Thank you for your review and it will be addressed.
>
> Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> 於 2022年5月10日 週二 下午6:59寫道:
> >
> > On 10/05/2022 12:03, Tyrone Ting wrote:
> > >
> > > maintainers:
> > > - Tali Perry <tali.perry1@...il.com>
> > >
> > > properties:
> > > compatible:
> > > - const: nuvoton,npcm750-i2c
> > > + enum:
> > > + - nuvoton,npcm750-i2c
> > > + - nuvoton,npcm845-i2c
> > >
> > > reg:
> > > maxItems: 1
> > > @@ -36,6 +37,10 @@ properties:
> > > default: 100000
> > > enum: [100000, 400000, 1000000]
> > >
> > > + nuvoton,sys-mgr:
> > > + $ref: "/schemas/types.yaml#/definitions/phandle"
> >
> > Minor nit: No quotes. The other places don't have it.
> >
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >
> >
> > Best regards,
> > Krzysztof
>
> Best regards,
> Tyrone
Powered by blists - more mailing lists