linux-kernel - Re: [PATCH] md: remove useless INIT_LIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 May 2022 08:38:24 +0200
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Haowen Bai <baihaowen@...zu.com>
Cc:     Song Liu <song@...nel.org>, linux-raid@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] md: remove useless INIT_LIST_HEAD()

Dear Haowen,


Thank you for your patch.

Am 11.05.22 um 04:44 schrieb Haowen Bai:
> list candidates has been inited staticly through LIST_HEAD,

initialized statically

> so there's no need to call another INIT_LIST_HEAD. Simply remove
> it.

Please reflow for 75 characters per line.

> Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> ---
>   drivers/md/md.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 707e802d0082..eb2b23ef5ecc 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -6491,7 +6491,6 @@ static void autorun_devices(int part)
>   					 struct md_rdev, same_set);
>   
>   		pr_debug("md: considering %s ...\n", bdevname(rdev0->bdev,b));
> -		INIT_LIST_HEAD(&candidates);
>   		rdev_for_each_list(rdev, tmp, &pending_raid_disks)
>   			if (super_90_load(rdev, rdev0, 0) >= 0) {
>   				pr_debug("md:  adding %s ...\n",


Kind regards,

Paul