linux-kernel - Re: [PATCH v4 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 May 2022 08:51:16 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>,
        linux-arm-kernel@...ts.infradead.org, soc@...nel.org,
        linux-serial@...r.kernel.org, sumit.garg@...aro.org
Cc:     arnd@...db.de, olof@...om.net, catalin.marinas@....com,
        will@...nel.org, gregkh@...uxfoundation.org,
        jason.wessel@...driver.com, daniel.thompson@...aro.org,
        dianders@...omium.org, linux-kernel@...r.kernel.org,
        kgdb-bugreport@...ts.sourceforge.net, peterz@...radead.org
Subject: Re: [PATCH v4 1/1] soc: fujitsu: Add A64FX diagnostic interrupt
 driver

On 11. 05. 22, 8:21, Hitomi Hasegawa wrote:
> --- /dev/null
> +++ b/drivers/soc/fujitsu/a64fx-diag.c
> @@ -0,0 +1,155 @@
...
> +#define BMC_DIAG_INTERRUPT_STATUS_OFFSET (0x0044)
> +#define BMC_DIAG_INTERRUPT_ENABLE_OFFSET (0x0040)

And I noticed here, I would:
* remove unneeded parentheses
* drop the "_OFFSET" suffix
* just write 8bit values (0x40, 0x44), given they fit
* order them numerically, 0x40 goes first

thanks,
-- 
js
suse labs