linux-kernel - Re: [PATCH V2 2/2] rtc: Introduce ti-k3-rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 May 2022 19:52:57 -0500
From:   Andrew Davis <afd@...com>
To:     Nishanth Menon <nm@...com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Alessandro Zummo <a.zummo@...ertech.it>
CC:     <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-rtc@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH V2 2/2] rtc: Introduce ti-k3-rtc

On 5/10/22 7:25 PM, Nishanth Menon wrote:
> Introduce support for Texas Instruments Real Time Clock controller on
> newer K3 family of SoCs such as AM62x.
> 
> The hardware module that is being supported is the "digital only"
> version which does'nt have capability of external wakeup sources and
> external power backup. However, for many practical applications, this
> should suffice as RTC is operational across low power sequences.
> 
> The hardware block by itself is split into two distinct domains
> internally to further reduce the power consumption with the actual
> counter block and comparators clocked off a 32k clock source (which
> based on SoC integration can be sourced by an external crystal) and an
> register interface block which is driven by the bus clock. While optimal
> from power perspective, it does create some complicated synchronizations
> and sequences that one must be wary of in the driver handling.
> 
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
> Changes since V1:
> (Andrew's comments):
> * Moved entirely to regmap fields - except for setting time, which I
>    have documented as to why regmap is necessary
> * Dropped the redundant MOD_ALIAS

Isn't regmap fun :)

Acked-by: Andrew Davis <afd@...com>