linux-kernel - Re: [PATCH v2 5/5] mm/memory-failure.c: simplify num_poisoned_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220511082011.GC211620@hori.linux.bs1.fc.nec.co.jp>
Date:   Wed, 11 May 2022 08:20:11 +0000
From:   HORIGUCHI NAOYA(堀口　直也) 
        <naoya.horiguchi@....com>
To:     zhenwei pi <pizhenwei@...edance.com>
CC:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 5/5] mm/memory-failure.c: simplify
 num_poisoned_pages_inc/dec

On Mon, May 09, 2022 at 06:56:41PM +0800, zhenwei pi wrote:
> Originally, do num_poisoned_pages_inc() in memory failure routine,
> use num_poisoned_pages_dec() to rollback the number if filtered/
> cancelled.
> 
> Suggested by Naoya, do num_poisoned_pages_inc() only in
> action_result(), this make this clear and simple.
> 
> Signed-off-by: zhenwei pi <pizhenwei@...edance.com>

I found that action_result(MF_MSG_UNKNOWN) in try_memory_failure_hugetlb()
does not follow the rule, so that could break the counter.
I don't think this is the issue in your patch, so I'm fine with this patch.

I'll submit a fix later for this, which will add hugetlb_set_page_hwpoison()
in the path.  That will have a bit non-trivial change because we need do
this in hugeltb_lock.

Anyway, thank you for this work.

Acked-by: Naoya Horiguchi <naoya.horiguchi@....com>