linux-kernel - Re: [PATCH -next] xtensa/simdisk: fix error handling in proc_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 May 2022 02:04:02 -0700
From:   Max Filippov <jcmvbkbc@...il.com>
To:     Yi Yang <yiyang13@...wei.com>
Cc:     Chris Zankel <chris@...kel.net>, Al Viro <viro@...iv.linux.org.uk>,
        "open list:TENSILICA XTENSA PORT (xtensa)" 
        <linux-xtensa@...ux-xtensa.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jens Axboe <axboe@...nel.dk>, wangweiyang2@...wei.com
Subject: Re: [PATCH -next] xtensa/simdisk: fix error handling in proc_read_simdisk()

Hi Yi,

On Tue, May 10, 2022 at 1:07 AM Yi Yang <yiyang13@...wei.com> wrote:
>
> The frist simple_read_from_buffer() will change ppos. if ppos >= 1.
> The second simple_read_from_buffer() will does not work and return 0.
>
> Fixes: a69755b18774 ("xtensa simdisk: switch to proc_create_data()")
> Signed-off-by: Yi Yang <yiyang13@...wei.com>
> ---
>  arch/xtensa/platforms/iss/simdisk.c | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)

Thank you for the fix. I've rearranged the patch a bit, expanding the commit
message and fixing the build warning that it introduced and have posted v2.
If there's no objections to it I'll add it to my xtensa tree.

-- 
Thanks.
-- Max