linux-kernel - Re: [PATCH V2] samsung-laptop: use kobj_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 May 2022 11:17:43 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     cgel.zte@...il.com
Cc:     Minghao Chi <chi.minghao@....com.cn>,
        Corentin Chary <corentin.chary@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mark Gross <markgross@...nel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH V2] samsung-laptop: use kobj_to_dev()

On Wed, May 11, 2022 at 4:15 AM <cgel.zte@...il.com> wrote:
>
> From: Minghao Chi <chi.minghao@....com.cn>
>
> Use kobj_to_dev() instead of open-coding it.

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> ---
> v1->v2:
>         remove Reported-by: Zeal Robot <zealci@....com.cn>

I believe you want to give credit to the bot in the future patches
like this. You may use commit message to add something like "The
suggestion has been given by Zeal Robot."

>  drivers/platform/x86/samsung-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
> index 19f6b456234f..c187dcdf82f0 100644
> --- a/drivers/platform/x86/samsung-laptop.c
> +++ b/drivers/platform/x86/samsung-laptop.c
> @@ -1208,7 +1208,7 @@ static int __init samsung_backlight_init(struct samsung_laptop *samsung)
>  static umode_t samsung_sysfs_is_visible(struct kobject *kobj,
>                                         struct attribute *attr, int idx)
>  {
> -       struct device *dev = container_of(kobj, struct device, kobj);
> +       struct device *dev = kobj_to_dev(kobj);
>         struct samsung_laptop *samsung = dev_get_drvdata(dev);
>         bool ok = true;
>
> --
> 2.25.1
>
>


-- 
With Best Regards,
Andy Shevchenko