linux-kernel - Re: [PATCH v6 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7219b406-7677-748b-984c-66009d9f6327@ti.com>
Date:   Wed, 11 May 2022 16:27:25 +0530
From:   "J, KEERTHY" <j-keerthy@...com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <robh+dt@...nel.org>, <daniel.lezcano@...aro.org>,
        <rui.zhang@...el.com>, <amitk@...nel.org>, <kristo@...nel.org>,
        <vigneshr@...com>
CC:     <linux-pm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings
 documentation



On 5/11/2022 1:45 PM, Krzysztof Kozlowski wrote:
> On 11/05/2022 09:53, J, KEERTHY wrote:
>>>>
>>>> Any comments on this version?
>>>
>>> You got Rob's review, so you don't need also mine.
>>>
>>> If you want, then in general look okay, except the description for "reg"
>>> you could split per items:
>>>
>>> reg:
>>>     items:
>>>       - description: VTM cfg1 register space
>>>       - description: VTM cfg2 register space
>>>       - description: efuse register space
>>>
>>> It's more obvious what items you expect.
>>
>> Hi Krzysztof,
>>
>> DTEX
>> Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dts
>> Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml: found
>> duplicate key "description" with value "VTM cfg2 register space"
>> (original value: "VTM cfg1 register space")
>> Documentation/devicetree/bindings/Makefile:26: recipe for target
>> 'Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dts'
>> failed
>> make[1]: ***
>> [Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dts] Er
>>
>> I believe multiple instances of description is failing. So can i keep
>> the description as is?
> 
> It looks weird. Can you share your code (pastebin/github/paste here)?

My bad. I had missed the '-' before description & hence it was erring 
out. I fixed. I will post v7 of this patch alone.

Thanks,
Keerthy

> 
> 
> Best regards,
> Krzysztof