linux-kernel - Re: [PATCH v5 2/7] firmware: sysfb: Add helpers to unregister a pdev and disable registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 May 2022 14:05:57 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org
Cc:     Daniel Vetter <daniel.vetter@...ll.ch>,
        Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v5 2/7] firmware: sysfb: Add helpers to unregister a pdev
 and disable registration

Hi

Am 11.05.22 um 14:01 schrieb Javier Martinez Canillas:
> Hello Thomas,
> 
> On 5/11/22 13:54, Thomas Zimmermann wrote:
>> Hi
>>
>> Am 11.05.22 um 13:24 schrieb Javier Martinez Canillas:
>>> These can be used by subsystems to unregister a platform device registered
>>> by sysfb and also to disable future platform device registration in sysfb.
>>>
>>
>> I find it very hard to review these patches, as related things are put
>> into separate patches.
>>
>> I suggest to put the sysfb_disable() stuff into patch 5 and the rest
>> into patch 4.
>>
> 
> Ok, you then want in the same patch to have both the helper definition
> and first usage.
> 
> Other subsystems ask you to do the opposite, to split the definition and
> usage in separate patches. But I'm fine with merging those if you prefer.

Usually, I have no strong opinion on this. But in the case of this 
specific patchset, I have the feeling that I'm missing some important 
point because call and implementation are separate.  See my other 
replies for that.  Putting them next to each other will hopefully help. 
Sorry for the inconvenience.

Best regards
Thomas

>   
>> Best regards
>> Thomas
>>
>>

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)