linux-kernel - Re: [PATCH v2] dt-bindings: gpio: gpio-mvebu: convert txt binding to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1652276215.699297.182486.nullmailer@robh.at.kernel.org>
Date:   Wed, 11 May 2022 08:36:55 -0500
From:   Rob Herring <robh@...nel.org>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     linus.walleij@...aro.org, devicetree@...r.kernel.org,
        linux-pwm@...r.kernel.org, thierry.reding@...il.com,
        krzysztof.kozlowski+dt@...aro.org, brgl@...ev.pl,
        robh+dt@...nel.org, linux-kernel@...r.kernel.org,
        lee.jones@...aro.org, u.kleine-koenig@...gutronix.de,
        linux-gpio@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: gpio: gpio-mvebu: convert txt binding to YAML

On Wed, 11 May 2022 13:37:37 +1200, Chris Packham wrote:
> Convert the existing device tree binding to YAML format.
> 
> The old binding listed the interrupt-controller and related properties
> as required but there are sufficiently many existing usages without it
> that the YAML binding does not make the interrupt properties required.
> 
> The offset and marvell,pwm-offset properties weren't in the old binding
> and are added to the YAML binding. The offset property is required when
> the marvell,armada-8k-gpio compatible is used.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> ---
> 
> Notes:
>     Changes in v2:
>     - Collect review from Andrew
>     - Remove unnecessary/obvious property descriptions
>     - Clarify reg property requirements for armadaxp vs the rest. Enforce
>       these with a variant specific constraint.
>     - Update compatible property requirements. marvell,orion-gpio and
>       marvell,armada-8k-gpio can be used on their own. Everything else needs
>       marvell,orion-gpio as a fallback.
>     - Correct example to include marvell,orion-gpio fallback
> 
>  .../devicetree/bindings/gpio/gpio-mvebu.txt   |  93 -----------
>  .../devicetree/bindings/gpio/gpio-mvebu.yaml  | 151 ++++++++++++++++++
>  MAINTAINERS                                   |   2 +-
>  3 files changed, 152 insertions(+), 94 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-mvebu.txt
>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-mvebu.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):
Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt: Documentation/devicetree/bindings/gpio/gpio-mvebu.txt
Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt: Documentation/devicetree/bindings/gpio/gpio-mvebu.txt

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.