linux-kernel - Re: [PATCH] ipmi:ipmb: Fix refcount leak in ipmi_ipmb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220512145224.GM3767252@minyard.net>
Date:   Thu, 12 May 2022 09:52:24 -0500
From:   Corey Minyard <minyard@....org>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi:ipmb: Fix refcount leak in ipmi_ipmb_probe

On Thu, May 12, 2022 at 08:44:45AM +0400, Miaoqian Lin wrote:
> of_parse_phandle() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.

Thanks, applied and backport requested for 5.17.

-corey

> 
> Fixes: 00d93611f002 ("ipmi:ipmb: Add the ability to have a separate slave and master device")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> ---
>  drivers/char/ipmi/ipmi_ipmb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/ipmi/ipmi_ipmb.c b/drivers/char/ipmi/ipmi_ipmb.c
> index b81b862532fb..a8bfe0ade082 100644
> --- a/drivers/char/ipmi/ipmi_ipmb.c
> +++ b/drivers/char/ipmi/ipmi_ipmb.c
> @@ -476,6 +476,7 @@ static int ipmi_ipmb_probe(struct i2c_client *client,
>  	slave_np = of_parse_phandle(dev->of_node, "slave-dev", 0);
>  	if (slave_np) {
>  		slave_adap = of_get_i2c_adapter_by_node(slave_np);
> +		of_node_put(slave_np);
>  		if (!slave_adap) {
>  			dev_notice(&client->dev,
>  				   "Could not find slave adapter\n");
> -- 
> 2.25.1
>