linux-kernel - Re: [PATCH 4/6] platform/chrome: cros_ec_proto: drop BUG_ON() in cros_ec_get_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABXOdTdrYPVSFGq6zmepM4jGEy0OmFog36S4faQbeL6G=OgGvw@mail.gmail.com>
Date:   Thu, 12 May 2022 08:12:04 -0700
From:   Guenter Roeck <groeck@...gle.com>
To:     Tzung-Bi Shih <tzungbi@...nel.org>
Cc:     Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        chrome-platform@...ts.linux.dev,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/6] platform/chrome: cros_ec_proto: drop BUG_ON() in cros_ec_get_host_event()

On Thu, May 12, 2022 at 1:36 AM Tzung-Bi Shih <tzungbi@...nel.org> wrote:
>
> It is overkill to crash the kernel if the `ec_dev` doesn't support MKBP
> event but gets called into cros_ec_get_host_event().
>
> Drop the BUG_ON() and return error (0 in the case) instead.
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@...nel.org>

Reviewed-by: Guenter Roeck <goeck@...omium.org>

> ---
>  drivers/platform/chrome/cros_ec_proto.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
> index 9ce3374846ff..ff767dccdf0f 100644
> --- a/drivers/platform/chrome/cros_ec_proto.c
> +++ b/drivers/platform/chrome/cros_ec_proto.c
> @@ -817,7 +817,8 @@ u32 cros_ec_get_host_event(struct cros_ec_device *ec_dev)
>  {
>         u32 host_event;
>
> -       BUG_ON(!ec_dev->mkbp_event_supported);
> +       if (!ec_dev->mkbp_event_supported)
> +               return 0;
>
>         if (ec_dev->event_data.event_type != EC_MKBP_EVENT_HOST_EVENT)
>                 return 0;
> --
> 2.36.0.512.ge40c2bad7a-goog
>