lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Thu, 12 May 2022 23:38:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ryan Lee <ryan.lee.analog@...il.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Mark Brown <broonie@...nel.org>
Subject: [broonie-ci:filegSObUR 100/158] sound/soc/codecs/max98396.c:1555:32:
 error: implicit declaration of function 'devm_gpiod_get_optional'; did you
 mean 'devm_regulator_get_optional'?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git filegSObUR
head:   0b7f644f52e81e2a653a353966933b47d01df9bb
commit: b58581136770569d2ee4300b10c7c0d76bb86250 [100/158] ASoC: max98396: add amplifier driver
config: sparc-buildonly-randconfig-r003-20220512 (https://download.01.org/0day-ci/archive/20220512/202205122316.V7tcZqcZ-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git/commit/?id=b58581136770569d2ee4300b10c7c0d76bb86250
        git remote add broonie-ci https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git
        git fetch --no-tags broonie-ci filegSObUR
        git checkout b58581136770569d2ee4300b10c7c0d76bb86250
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash sound/soc/codecs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

Note: the broonie-ci/filegSObUR HEAD 0b7f644f52e81e2a653a353966933b47d01df9bb builds fine.
      It only hurts bisectability.

All errors (new ones prefixed by >>):

   sound/soc/codecs/max98396.c: In function 'max98396_i2c_probe':
>> sound/soc/codecs/max98396.c:1555:32: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_regulator_get_optional'? [-Werror=implicit-function-declaration]
    1555 |         max98396->reset_gpio = devm_gpiod_get_optional(&i2c->dev,
         |                                ^~~~~~~~~~~~~~~~~~~~~~~
         |                                devm_regulator_get_optional
>> sound/soc/codecs/max98396.c:1556:65: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function); did you mean 'GPIOF_INIT_HIGH'?
    1556 |                                                        "reset", GPIOD_OUT_HIGH);
         |                                                                 ^~~~~~~~~~~~~~
         |                                                                 GPIOF_INIT_HIGH
   sound/soc/codecs/max98396.c:1556:65: note: each undeclared identifier is reported only once for each function it appears in
>> sound/soc/codecs/max98396.c:1565:17: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration]
    1565 |                 gpiod_set_value_cansleep(max98396->reset_gpio, 0);
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~
         |                 gpio_set_value_cansleep
   cc1: some warnings being treated as errors


vim +1555 sound/soc/codecs/max98396.c

  1514	
  1515	static int max98396_i2c_probe(struct i2c_client *i2c,
  1516				      const struct i2c_device_id *id)
  1517	{
  1518		struct max98396_priv *max98396 = NULL;
  1519		int ret, reg;
  1520	
  1521		max98396 = devm_kzalloc(&i2c->dev, sizeof(*max98396), GFP_KERNEL);
  1522	
  1523		if (!max98396) {
  1524			ret = -ENOMEM;
  1525			return ret;
  1526		}
  1527		i2c_set_clientdata(i2c, max98396);
  1528	
  1529		max98396->device_id =  id->driver_data;
  1530	
  1531		/* regmap initialization */
  1532		if (max98396->device_id == CODEC_TYPE_MAX98396)
  1533			max98396->regmap = devm_regmap_init_i2c(i2c, &max98396_regmap);
  1534	
  1535		else
  1536			max98396->regmap = devm_regmap_init_i2c(i2c, &max98397_regmap);
  1537	
  1538		if (IS_ERR(max98396->regmap)) {
  1539			ret = PTR_ERR(max98396->regmap);
  1540			dev_err(&i2c->dev,
  1541				"Failed to allocate regmap: %d\n", ret);
  1542			return ret;
  1543		}
  1544	
  1545		/* update interleave mode info */
  1546		if (device_property_read_bool(&i2c->dev, "adi,interleave_mode"))
  1547			max98396->interleave_mode = true;
  1548		else
  1549			max98396->interleave_mode = false;
  1550	
  1551		/* voltage/current slot & gpio configuration */
  1552		max98396_read_device_property(&i2c->dev, max98396);
  1553	
  1554		/* Reset the Device */
> 1555		max98396->reset_gpio = devm_gpiod_get_optional(&i2c->dev,
> 1556							       "reset", GPIOD_OUT_HIGH);
  1557		if (IS_ERR(max98396->reset_gpio)) {
  1558			ret = PTR_ERR(max98396->reset_gpio);
  1559			dev_err(&i2c->dev, "Unable to request GPIO pin: %d.\n", ret);
  1560			return ret;
  1561		}
  1562	
  1563		if (max98396->reset_gpio) {
  1564			usleep_range(5000, 6000);
> 1565			gpiod_set_value_cansleep(max98396->reset_gpio, 0);
  1566			/* Wait for the hw reset done */
  1567			usleep_range(5000, 6000);
  1568		}
  1569	
  1570		ret = regmap_read(max98396->regmap,
  1571				  GET_REG_ADDR_REV_ID(max98396->device_id), &reg);
  1572		if (ret < 0) {
  1573			dev_err(&i2c->dev, "%s: failed to read revision of the device.\n",  id->name);
  1574			return ret;
  1575		}
  1576		dev_info(&i2c->dev, "%s revision ID: 0x%02X\n", id->name, reg);
  1577	
  1578		/* codec registration */
  1579		if (max98396->device_id == CODEC_TYPE_MAX98396)
  1580			ret = devm_snd_soc_register_component(&i2c->dev,
  1581							      &soc_codec_dev_max98396,
  1582							      max98396_dai,
  1583							      ARRAY_SIZE(max98396_dai));
  1584		else
  1585			ret = devm_snd_soc_register_component(&i2c->dev,
  1586							      &soc_codec_dev_max98397,
  1587							      max98397_dai,
  1588							      ARRAY_SIZE(max98397_dai));
  1589		if (ret < 0)
  1590			dev_err(&i2c->dev, "Failed to register codec: %d\n", ret);
  1591	
  1592		return ret;
  1593	}
  1594	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Powered by blists - more mailing lists