linux-kernel - Re: [RFC] KTAP spec v2: prefix to KTAP data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 May 2022 12:26:33 -0500
From:   Frank Rowand <frowand.list@...il.com>
To:     Daniel Latypov <dlatypov@...gle.com>
Cc:     David Gow <davidgow@...gle.com>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Kees Cook <keescook@...omium.org>, Tim.Bird@...y.com,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Jonathan Corbet <corbet@....net>, rmr167@...il.com,
        guillaume.tucker@...labora.com, kernelci@...ups.io,
        kunit-dev@...glegroups.com, linux-kselftest@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC] KTAP spec v2: prefix to KTAP data

On 5/12/22 10:25, Daniel Latypov wrote:
> On Wed, May 11, 2022 at 11:01 PM Frank Rowand <frowand.list@...il.com> wrote:
>> ================================================================================
>> #### discussion notes:
>>
>> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
>> PRO: minimally invasive to specification.
>>
>> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
>> CON:
>>
>> KTAP does not include any mechanism to describe the value of <prefix string>
>> to test harnesses and test output processing programs.  The test output
>> processing programs must infer the value of <prefix string> by detecting
>> the <prefix string> in the "Version lines".
>>
>> The detection of a "Version lines" might be a match of the regex:
>>
>>    "^.*KTAP version 2$"
>>
>> This risks falsely detecting a "Version lines", but the risk is small???
> 
> Agree this is a risk and also think it's probably small, but it's hard to say.
> I think the $ anchoring the regex is probably safe enough.
> 
> As noted earlier, this tracks with what kunit.py already does.
> That was necessitated by dynamic prefixes such as timestamps, etc.f

That is a good observation.  I nearly always have the prefix timestamp
on my console output, and thus remove the timestamp with a regex when
processing the data.

-Frank

> So I think this is probably a fine risk to take.
> 
> I imagine we could add constraints of prefix string, e.g. must have []
> around it, etc. if we want to try and minimize this risk.
> But I don't know if it's necessarily worth it, given what we know right now.
> 
> Along those lines, I think I like this approach (Alternative 1) more
> than Alternative 2/2b.
> I'm not sure we need a structured way to specify metadata in KTAP yet?
> The prefix seems like a reasonable candidate, but do others have ideas
> of other bits of metadata we'd want to be able to declare?
> 
> Daniel