linux-kernel - Re: [PATCH net-next v7 2/2] net: vxlan: Add extack support to vxlan_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220512175055.65ftcpkig3t3ttsq@skbuf>
Date:   Thu, 12 May 2022 17:50:56 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
CC:     Jakub Kicinski <kuba@...nel.org>, Roopa Prabhu <roopa@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "outreachy@...ts.linux.dev" <outreachy@...ts.linux.dev>,
        "jdenham@...hat.com" <jdenham@...hat.com>,
        "sbrivio@...hat.com" <sbrivio@...hat.com>,
        "jesse.brandeburg@...el.com" <jesse.brandeburg@...el.com>,
        "anthony.l.nguyen@...el.com" <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "shshaikh@...vell.com" <shshaikh@...vell.com>,
        "manishc@...vell.com" <manishc@...vell.com>,
        "razor@...ckwall.org" <razor@...ckwall.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "GR-Linux-NIC-Dev@...vell.com" <GR-Linux-NIC-Dev@...vell.com>,
        "bridge@...ts.linux-foundation.org" 
        <bridge@...ts.linux-foundation.org>
Subject: Re: [PATCH net-next v7 2/2] net: vxlan: Add extack support to
 vxlan_fdb_delete

On Thu, May 12, 2022 at 10:17:13AM -0700, Roopa Prabhu wrote:
> 
> On 5/12/22 09:47, Jakub Kicinski wrote:
> > On Thu, 12 May 2022 09:22:17 -0700 Roopa Prabhu wrote:
> > > On 5/12/22 02:55, Alaa Mohamed wrote:
> > > > This patch adds extack msg support to vxlan_fdb_delete and vxlan_fdb_parse.
> > > > extack is used to propagate meaningful error msgs to the user of vxlan
> > > > fdb netlink api
> > > > 
> > > > Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
> > Also the patches don't apply to net-next, again.
> 
> that's probably because the patches were already applied. Ido just told me
> abt it also
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=5dd6da25255a9d64622c693b99d7668da939a980
> 
> I have requested Alaa send an incremental fix (offline).
> 
> thanks
>

Alaa, when you send the incremental fixup patch requested by Roopa,
could you please also:

- properly align the extack argument of the ocelot_port_fdb_del()
  function
- properly align the extack argument of the vxlan_fdb_delete() function
- properly align the "DST, VNI, ifindex and port are mutually exclusive with NH_ID"
  string to the open parenthesis of the NL_SET_ERR_MSG macro in vxlan_fdb_parse().
- make actual use of the extack in ice_fdb_add() and ice_fdb_del(), and
  remove the __always_unused from ice_fdb_add().

Thank you.