linux-kernel - Re: [PATCH v6 04/23] kunit: take `kunit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFd5g47skTReYjQDHdv=V52+E-1odLsTJMn6E3GV7N7mYia=bA@mail.gmail.com>
Date:   Thu, 12 May 2022 15:01:21 -0400
From:   Brendan Higgins <brendanhiggins@...gle.com>
To:     Miguel Ojeda <ojeda@...nel.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jarkko Sakkinen <jarkko@...nel.org>,
        Daniel Latypov <dlatypov@...gle.com>,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com
Subject: Re: [PATCH v6 04/23] kunit: take `kunit_assert` as `const`

On Sat, May 7, 2022 at 1:26 AM Miguel Ojeda <ojeda@...nel.org> wrote:
>
> The `kunit_do_failed_assertion` function passes its
> `struct kunit_assert` argument to `kunit_fail`. This one,
> in turn, calls its `format` field passing the assert again
> as a `const` pointer.
>
> Therefore, the whole chain may be made `const`.
>
> Reviewed-by: Daniel Latypov <dlatypov@...gle.com>
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>

Reviewed-by: Brendan Higgins <brendanhiggins@...gle.com>