linux-kernel - Re: [PATCH v5 01/12] modpost: split the section mismatch checks into section-check.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNASsnrxu1BvtR9aq6oeOvmTX8jr4Wum=+7qemKzcLpSRWQ@mail.gmail.com>
Date:   Thu, 12 May 2022 12:32:14 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nicolas Schier <nicolas@...sle.eu>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-modules <linux-modules@...r.kernel.org>,
        clang-built-linux <llvm@...ts.linux.dev>,
        Ard Biesheuvel <ardb@...nel.org>,
        Sami Tolvanen <samitolvanen@...gle.com>
Subject: Re: [PATCH v5 01/12] modpost: split the section mismatch checks into section-check.c

On Thu, May 12, 2022 at 7:28 AM Nick Desaulniers
<ndesaulniers@...gle.com> wrote:
>
> On Wed, May 11, 2022 at 9:49 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
> >
> > modpost.c is too big, and the half of the code is for section checks.
> > Split it.
> >
> > Also, move some related typedefs and macros from modpost.h to
> > section-check.c
> >
> > Copy Sam's Copyright there. Commit b39927cf4cc5 ("kbuild: check for
> > section mismatch during modpost stage") is the initial work for the
> > section checks.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
>
> Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>
>
> Sorry again for my "brain fart" in reviewing the global var in v4. :(
> I think my blood sugar was getting low or something...

Never mind.
Thanks for the close review all the time!

>
> > ---
> >
> > Changes in v5:
> >    - Fix the build error  (spotted by Nathan)
> >    - Do not do codying style changes  (Suggested by Nick)
>
> I'm surprised the style changes didn't show up in v5 as a later patch
> in the series. I wasn't against them in general, just thought it would
> be easier to review if they were distinct commits.


I just postponed the coding style fixes
because they are not essential for my main goal
in this patch set.

A lot of old code exists in modpost.
We can improve it later.


-- 
Best Regards
Masahiro Yamada