linux-kernel - Re: [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACD3sJbiPYcckyLncXcVR-TFBo_-3XwSDYbmid4qwnoHX-JtUw@mail.gmail.com>
Date:   Thu, 12 May 2022 09:31:05 +0800
From:   Tyrone Ting <warp5tw@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     sven@...npeter.dev, JJLIU0@...oton.com,
        linux-kernel@...r.kernel.org, olof@...om.net,
        lukas.bulwahn@...il.com, jarkko.nikula@...ux.intel.com,
        yuenn@...gle.com, arnd@...db.de, tali.perry1@...il.com,
        openbmc@...ts.ozlabs.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-i2c@...r.kernel.org,
        tmaimon77@...il.com, benjaminfair@...gle.com,
        tomer.maimon@...oton.com, kfting@...oton.com,
        semen.protsenko@...aro.org, Avi.Fishman@...oton.com,
        jsd@...ihalf.com, wsa@...nel.org, devicetree@...r.kernel.org,
        andriy.shevchenko@...ux.intel.com, KWLIU@...oton.com,
        tali.perry@...oton.com, avifishman70@...il.com, venture@...gle.com
Subject: Re: [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845

Hi Rob:

Thank you for your review. I would like to apply Krzysztof's comment
from the link https://www.spinics.net/lists/linux-i2c/msg56795.html
and remove the
quotes of the statement "$ref: "/schemas/types.yaml#/definitions/phandle"".

If it's okay with you, I'll come up with a new patch with
"Reviewed-by" from you and Krzysztof.

Thank you.

Rob Herring <robh@...nel.org> 於 2022年5月11日 週三 下午11:24寫道：
>
> On Tue, 10 May 2022 17:16:46 +0800, Tyrone Ting wrote:
> > From: Tyrone Ting <kfting@...oton.com>
> >
> > Add compatible and nuvoton,sys-mgr description for NPCM i2c module.
> >
> > Signed-off-by: Tyrone Ting <kfting@...oton.com>
> > ---
> >  .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml     | 25 +++++++++++++++----
> >  1 file changed, 20 insertions(+), 5 deletions(-)
> >
>
> Reviewed-by: Rob Herring <robh@...nel.org>

Best Regards,
Tyrone