linux-kernel - Re: [PATCH] drivers:Modify the return value to void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23cf0d6b-3577-b9c1-e20d-e54b6823f309@suse.com>
Date:   Thu, 12 May 2022 11:58:08 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Zhou jie <zhoujie@...china.com>, Johan Hovold <johan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:Modify the return value to void



On 12.05.22 11:32, Zhou jie wrote:
> drivers:Modify the return value to void

Hi,

technically the patch is obviously correct. Yet, it is not a good idea.
write_mos_reg() can fail and hiding errors is not a good strategy.
You'd better propagate the error.

    Regards
        Oliver