linux-kernel - Re: [PATCH] ARM: meson: Fix refcount leak in meson_smp_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCCJYjunsRjKmgxwBkQu+aL-42TPdSrCi1g=0jofXeYe+A@mail.gmail.com>
Date:   Thu, 12 May 2022 12:56:17 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Russell King <linux@...linux.org.uk>,
        Neil Armstrong <narmstrong@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Carlo Caione <carlo@...lessm.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: meson: Fix refcount leak in meson_smp_prepare_cpus

On Thu, May 12, 2022 at 4:16 AM Miaoqian Lin <linmq006@...il.com> wrote:
>
> of_find_compatible_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: d850f3e5d296 ("ARM: meson: Add SMP bringup code for Meson8 and Meson8b")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>

Thank you for spotting and fixing this issue!