linux-kernel - Re: [PATCH 5.10] arm: remove CONFIG_ARCH_HAS_HOLES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 May 2022 15:47:20 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mike Rapoport <rppt@...nel.org>
Cc:     Mark-PK Tsai <mark-pk.tsai@...iatek.com>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Russell King <linux@...linux.org.uk>, kbuild-all@...ts.01.org,
        kernel test robot <lkp@...el.com>,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        stable@...r.kernel.org
Subject: Re: [PATCH 5.10] arm: remove CONFIG_ARCH_HAS_HOLES_MEMORYMODEL

On Tue, May 10, 2022 at 08:15:23PM +0300, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@...ux.ibm.com>
> 
> commit 5e545df3292fbd3d5963c68980f1527ead2a2b3f upstream.
> 
> ARM is the only architecture that defines CONFIG_ARCH_HAS_HOLES_MEMORYMODEL
> which in turn enables memmap_valid_within() function that is intended to
> verify existence  of struct page associated with a pfn when there are holes
> in the memory map.
> 
> However, the ARCH_HAS_HOLES_MEMORYMODEL also enables HAVE_ARCH_PFN_VALID
> and arch-specific pfn_valid() implementation that also deals with the holes
> in the memory map.
> 
> The only two users of memmap_valid_within() call this function after
> a call to pfn_valid() so the memmap_valid_within() check becomes redundant.
> 
> Remove CONFIG_ARCH_HAS_HOLES_MEMORYMODEL and memmap_valid_within() and rely
> entirely on ARM's implementation of pfn_valid() that is now enabled
> unconditionally.
> 
> Link: https://lkml.kernel.org/r/20201101170454.9567-9-rppt@kernel.org
> Signed-off-by: Mike Rapoport <rppt@...ux.ibm.com>
> Cc: Alexey Dobriyan <adobriyan@...il.com>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Greg Ungerer <gerg@...ux-m68k.org>
> Cc: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
> Cc: Jonathan Corbet <corbet@....net>
> Cc: Matt Turner <mattst88@...il.com>
> Cc: Meelis Roos <mroos@...ux.ee>
> Cc: Michael Schmitz <schmitzmic@...il.com>
> Cc: Russell King <linux@...linux.org.uk>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: Vineet Gupta <vgupta@...opsys.com>
> Cc: Will Deacon <will@...nel.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 8dd559d53b3b ("arm: ioremap: don't abuse pfn_valid() to check if pfn is in RAM")
> Signed-off-by: Mike Rapoport <rppt@...ux.ibm.com>
> ---
>  Documentation/vm/memory-model.rst |  3 +--
>  arch/arm/Kconfig                  |  8 ++------
>  arch/arm/mach-bcm/Kconfig         |  1 -
>  arch/arm/mach-davinci/Kconfig     |  1 -
>  arch/arm/mach-exynos/Kconfig      |  1 -
>  arch/arm/mach-highbank/Kconfig    |  1 -
>  arch/arm/mach-omap2/Kconfig       |  1 -
>  arch/arm/mach-s5pv210/Kconfig     |  1 -
>  arch/arm/mach-tango/Kconfig       |  1 -
>  fs/proc/kcore.c                   |  2 --
>  include/linux/mmzone.h            | 31 -------------------------------
>  mm/mmzone.c                       | 14 --------------
>  mm/vmstat.c                       |  4 ----
>  13 files changed, 3 insertions(+), 66 deletions(-)

Both now queued up, thanks.

greg k-h