linux-kernel - Re: [PATCH] kunit: tool: stop using a shell to run kernel under QEMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGS_qxro7Az_yJfjQYK0+0u2mu9E62xmRPD_8EKiq8ZNEd6qUg@mail.gmail.com>
Date:   Thu, 12 May 2022 07:28:09 -0700
From:   Daniel Latypov <dlatypov@...gle.com>
To:     Brendan Higgins <brendanhiggins@...gle.com>
Cc:     davidgow@...gle.com, linux-kernel@...r.kernel.org,
        kunit-dev@...glegroups.com, linux-kselftest@...r.kernel.org,
        skhan@...uxfoundation.org
Subject: Re: [PATCH] kunit: tool: stop using a shell to run kernel under QEMU

On Wed, May 11, 2022 at 4:22 PM Brendan Higgins
<brendanhiggins@...gle.com> wrote:
> > +                          extra_qemu_params=[])
> > diff --git a/tools/testing/kunit/qemu_configs/powerpc.py b/tools/testing/kunit/qemu_configs/powerpc.py
> > index 35e9de24f0db..6c901149726b 100644
> > --- a/tools/testing/kunit/qemu_configs/powerpc.py
> > +++ b/tools/testing/kunit/qemu_configs/powerpc.py
> > @@ -9,4 +9,4 @@ CONFIG_HVC_CONSOLE=y''',
> >                            qemu_arch='ppc64',
> >                            kernel_path='vmlinux',
> >                            kernel_command_line='console=ttyS0',
> > -                          extra_qemu_params=['-M pseries', '-cpu power8'])
> > +                          extra_qemu_params=['-M', ' pseries', '-cpu', 'power8'])
>
> This should be '-M', 'pseries', not '-M', ' pseries', (you left an
> extra space in.
>
> Note this actually breaks QEMU on my machine.

Thanks for catching this!

Ugh, I must have sent out a stale version of the .patch file.
My tree has the fix since I noticed it right as I was preparing to
send this out.

I have this locally:
-                          extra_qemu_params=['-M pseries', '-cpu power8'])
+                          extra_qemu_params=['-M', 'pseries', '-cpu',
'power8'])

Sent out as v2,
https://lore.kernel.org/linux-kselftest/20220512142555.3554396-1-dlatypov@google.com