linux-kernel - Re: [PATCH v2 4/4] dt-bindings: arm: qcom: Add more sc7180 Chromebook board bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=VpdfrkKJg8bgtTEACxH5VP+rXG0MTXPARi3S1htuqbSg@mail.gmail.com>
Date:   Fri, 13 May 2022 13:44:38 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Rob Herring <robh@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rajendra Nayak <quic_rjendra@...cinc.com>,
        Alexandru M Stan <amstan@...omium.org>,
        Julius Werner <jwerner@...omium.org>,
        "Joseph S . Barrera III" <joebar@...omium.org>,
        Andy Gross <agross@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Stephen Boyd <sboyd@...eaurora.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/4] dt-bindings: arm: qcom: Add more sc7180 Chromebook
 board bindings

Hi,

On Fri, May 13, 2022 at 1:37 PM Matthias Kaehlcke <mka@...omium.org> wrote:
>
> On Fri, May 13, 2022 at 09:59:20AM -0700, Douglas Anderson wrote:
> > This adds board bindings for boards that are downstream but not quite
> > upstream yet.
> >
> > Signed-off-by: Douglas Anderson <dianders@...omium.org>
>
> I didn't follow the discussion about the odd sku ids (-sku1537,
> -sku1536, -sku1024, ...), but they match what is in the
> downstream tree, so it seems alright :)

It makes more sense in hex. hex(1536) = 0x600. Basically on these
boards there are two sets of GPIO strappings, the normal SKU
strappings and the panel strappings. Depthcharge combines them. You
end up with an ugly decimal number, but it's not the end of the world.

-Doug