linux-kernel - Re: [PATCH] ata: Remove unneeded ERROR check before clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9772e83-3f1e-0d05-abbb-07f2382e3cd5@omp.ru>
Date:   Sat, 14 May 2022 00:01:26 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Wan Jiabing <wanjiabing@...o.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        <linux-ide@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ata: Remove unneeded ERROR check before
 clk_disable_unprepare

On 5/13/22 10:55 AM, Wan Jiabing wrote:

> ERROR check is already in clk_disable() and clk_unprepare() by using
> IS_ERR_OR_NULL. Remove unneeded ERROR check for ftide->pclk here.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]

MBR, Sergey