linux-kernel - Re: [PATCH -next v2 1/2] block, bfq: protect 'bfqd->queued' by 'bfqd->lock'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76d12440-83f9-963b-da3b-94cb7ae26d94@nvidia.com>
Date:   Fri, 13 May 2022 06:13:02 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Yu Kuai <yukuai3@...wei.com>, "jack@...e.cz" <jack@...e.cz>,
        "paolo.valente@...aro.org" <paolo.valente@...aro.org>,
        "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "yi.zhang@...wei.com" <yi.zhang@...wei.com>
Subject: Re: [PATCH -next v2 1/2] block, bfq: protect 'bfqd->queued' by
 'bfqd->lock'

On 5/12/2022 7:35 PM, Yu Kuai wrote:
> If bfq_schedule_dispatch() is called from bfq_idle_slice_timer_body(),
> then 'bfqd->queued' is read without holding 'bfqd->lock'. This is
> wrong since it can be wrote concurrently.
> 
> Fix the problem by holding 'bfqd->lock' in such case.
> 
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> Reviewed-by: Jan Kara <jack@...e.cz>
> ---

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck