linux-kernel - Re: [PATCH] ARM: milbeaut: Fix refcount leak in m10v_smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b323f86-79e3-f219-58d2-0a48330b92e4@socionext.com>
Date:   Fri, 13 May 2022 15:51:57 +0900
From:   Sugaya Taichi <sugaya.taichi@...ionext.com>
To:     Miaoqian Lin <linmq006@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Takao Orito <orito.takao@...ionext.com>,
        Arnd Bergmann <arnd@...db.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: milbeaut: Fix refcount leak in m10v_smp_init

Thank you for the patch!

Acked-by: Sugaya Taichi <sugaya.taichi@...ionext.com>


On 2022/05/12 17:15, Miaoqian Lin wrote:
> of_find_compatible_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: 9fb29c734f9e ("ARM: milbeaut: Add basic support for Milbeaut m10v SoC")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> ---
>   arch/arm/mach-milbeaut/platsmp.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-milbeaut/platsmp.c b/arch/arm/mach-milbeaut/platsmp.c
> index 3ea880f5fcb7..1f1ff21c7140 100644
> --- a/arch/arm/mach-milbeaut/platsmp.c
> +++ b/arch/arm/mach-milbeaut/platsmp.c
> @@ -53,6 +53,7 @@ static void m10v_smp_init(unsigned int max_cpus)
>   		return;
>   
>   	m10v_smp_base = of_iomap(np, 0);
> +	of_node_put(np);
>   	if (!m10v_smp_base)
>   		return;
>   
>