linux-kernel - Re: [PATCH V4 2/5] dt-bindings: clock: Document MA35D1 clock controller bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 May 2022 08:54:23 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Jacky Huang <ychuang3@...oton.com>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, ychuang570808@...il.com
Cc:     robh+dt@...nel.org, sboyd@...nel.org, krzk+dt@...nel.org,
        arnd@...db.de, olof@...om.net, catalin.marinas@....com,
        will@...nel.org, soc@...nel.org, cfli0@...oton.com
Subject: Re: [PATCH V4 2/5] dt-bindings: clock: Document MA35D1 clock
 controller bindings

On 13/05/2022 08:25, Jacky Huang wrote:
> 
> 
> On 2022/5/12 下午 10:04, Krzysztof Kozlowski wrote:
>> On 10/05/2022 05:25, Jacky Huang wrote:
>>> Add documentation to describe Nuvoton MA35D1 clock driver bindings.
>>>
>>> Signed-off-by: Jacky Huang <ychuang3@...oton.com>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> +  - |
>>> +    #include <dt-bindings/clock/nuvoton,ma35d1-clk.h>
>>> +
>>> +    clk: clock-controller@...60200 {
>>> +        compatible = "nuvoton,ma35d1-clk";
>>> +        reg = <0x0 0x40460200 0x0 0x100>;
>> I don't think you tested your bindings. This fails.
>>
>> clock-names below as well. Please do not send untested code.
>>
>> Testing is explained here:
>> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv5.18-rc6%2Fsource%2FDocumentation%2Fdevicetree%2Fbindings%2Fwriting-schema.rst%23L111&amp;data=05%7C01%7Cychuang3%40nuvoton.com%7C7f9b081f94a642e8b40b08da34204e53%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C637879610603173566%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=kqInjscLvZpOSWtsN%2BPW3s%2BPeaK5KCD1weTH2JiHqxg%3D&amp;reserved=0
>>
>> Best regards,
>> Krzysztof
> 
> I run the test  make DT_CHECKER_FLAGS=-m dt_binding_check, but not run 
> dtbs_check.

It is the `make dt_binding_check` which fails here, so what do you mean
that you run it? It cannot pass, the code is clearly not correct.


Best regards,
Krzysztof