linux-kernel - 回复: [PATCH] bus: mhi: host: Add support for Quectel EM120 FCCL project.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MEYP282MB2374FA30A8EFF7CC25E256C7FDCA9@MEYP282MB2374.AUSP282.PROD.OUTLOOK.COM>
Date:   Fri, 13 May 2022 08:22:30 +0000
From:   谭 永林 <yonglin.tan@...look.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "mani@...nel.org" <mani@...nel.org>,
        "quic_hemantk@...cinc.com" <quic_hemantk@...cinc.com>,
        "loic.poulain@...aro.org" <loic.poulain@...aro.org>,
        "mhi@...ts.linux.dev" <mhi@...ts.linux.dev>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 回复: [PATCH]     bus: mhi: host: Add support for Quectel EM120 FCCL project.

Dear Greg,

Thanks for your advice. I will try to learn the tutorial. 

-----邮件原件-----
发件人: Greg KH <gregkh@...uxfoundation.org> 
发送时间: 2022年5月13日 15:10
收件人: Yonglin Tan <yonglin.tan@...look.com>
抄送: mani@...nel.org; quic_hemantk@...cinc.com; loic.poulain@...aro.org; mhi@...ts.linux.dev; linux-arm-msm@...r.kernel.org; linux-kernel@...r.kernel.org
主题: Re: [PATCH] bus: mhi: host: Add support for Quectel EM120 FCCL project.

On Fri, May 13, 2022 at 03:00:25PM +0800, Yonglin Tan wrote:
> From: ylintan <yonglin.tan@...look.com>
> 
>     This patch add VendorID/DeviceID definitions for EM120 FCCL project.
>     It has the same configration as Quectel EM160R-GL and EM120R-GL.
> 
>     Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>     Reviewed-by: Hemant Kumar <hemantk@...eaurora.org>
>     Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>     Signed-off-by: Yonglin Tan <yonglin.tan@...look.com>
> ---
>  drivers/bus/mhi/host/pci_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> +	{ PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> +		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
>  	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
>  		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> -- 
> 2.7.4
> 

Ok, please stop and take a minute and go through the basic "how do I
write a kernel patch" tutorial on kernelnewbies.org.

You are submitting a patch that has a number of obvious things wrong
with it:
	- invalid from: line that does not match the signed-off-by line
	- made up out of thin air "reviewed-by:" lines from people who
	  have OBVIOUSLY NOT REVIEWED THIS PATCH!
	- indented changelog text in an odd format
	- extra spaces in the subject line
	- no versioning in the subject line, or below the --- line as
	  the documentation requires

Please take some time off, and come back next week with this all fixed
up AFTER you have gone through the kernelnewbies tutorial AND you have
read all of the Documentation/process/submitting-patches.rst file.

thanks,

greg k-h