[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <SL2PR06MB3082CAA7318834D00872DE0DBDCA9@SL2PR06MB3082.apcprd06.prod.outlook.com>
Date: Fri, 13 May 2022 08:30:10 +0000
From: 王擎 <wangqing@...o.com>
To: Sudeep Holla <sudeep.holla@....com>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"dietmar.eggemann@....com" <dietmar.eggemann@....com>
Subject: [PATCH V2] arch_topology: support parsing cluster_id from DT
>> From: Wang Qing <wangqing@...o.com>
>>
>> Use nested cluster structures in DT to support describing multi-level
>> cluster topologies and increase the parsing of nested cluster.
>>
>> Notice: the clusters describing in DT currently are not physical
>> boundaries, since changing "cluster" to "socket" is too involved and error
>> prone, this patch will not have any effect on one-level cluster topo, but
>> can support the mutil-level cluster topo to support CLUSTER_SCHED.
>
>Sorry the socket/package_id is broken. If we are playing with cluster_id
>which is now wrongly presented as package_id, you are forced to fix that
>too. We don't want to break that in a different way or leave that as is
>since the cluster_id and package ids now show up as same now. Earlier the
>cluster_id was -1.
>
>I had a look when I started reviewing your patch. Assuming we don't need
>nested cluster support yet, I have some patches(not built or tested
>unfortunately yet). Let me know your thoughts. If you think you still
>need support for some kind of nested cluster, build that on top of this.
>Also I haven't bothered about sched domains as this purely relates to
>topology and how this is mapped to sched domain is orthogonal.
>
>If anything is broken, that needs to be fixed separately there. I see the
>idea here is correct and would like to push the patches once I build/test
>and get some review/more testing.
>
>Regards,
>Sudeep
You have to modify all DTS(rename "cluster" to "socket"), otherwise,
new package_id = -1 and new cluster_id = old package_id.
This will affect MC and CLS useage, do you have any plans about this?
Thanks,
Qing
>
>...
Powered by blists - more mailing lists