linux-kernel - Re: [PATCH 2/2] random: move initialization out of reseeding hot path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yn4xLowv+farg814@zx2c4.com>
Date:   Fri, 13 May 2022 12:21:34 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Dominik Brodowski <linux@...inikbrodowski.net>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] random: move initialization out of reseeding hot path

Hi Dominik,

On Fri, May 13, 2022 at 08:24:19AM +0200, Dominik Brodowski wrote:
> > -	if (!crng_ready()) {
> > -		crng_init = CRNG_READY;
> > -		finalize_init = true;
> > -	}
> > +	crng_init = CRNG_READY;
> 
> Why unconditionally

To avoid a useless branch.

> (you revert that bit in the static branch patch and make
> it conditional again; so I see no reason for that here)?

With the static branch patch, I can totally remove the branch and the
store all together, so we get the best of both worlds.

Jason