[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220513122248.146d6944@xps13>
Date: Fri, 13 May 2022 12:22:48 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Yang Yingliang <yangyingliang@...wei.com>
Cc: <linux-kernel@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
<richard@....at>, <vigneshr@...com>
Subject: Re: [PATCH -next] mtd: st_spi_fsm: add missing
clk_disable_unprepare() stfsm_remove()
Hi,
yangyingliang@...wei.com wrote on Fri, 13 May 2022 18:03:22 +0800:
> Clock source is prepared and enabled by clk_prepare_enable()
> in probe function, but no disable or unprepare in remove function.
not disabled or unprepared
Otherwise looks good.
>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
> drivers/mtd/devices/st_spi_fsm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
> index 983999c020d6..d3377b10fc0f 100644
> --- a/drivers/mtd/devices/st_spi_fsm.c
> +++ b/drivers/mtd/devices/st_spi_fsm.c
> @@ -2126,6 +2126,8 @@ static int stfsm_remove(struct platform_device *pdev)
> {
> struct stfsm *fsm = platform_get_drvdata(pdev);
>
> + clk_disable_unprepare(fsm->clk);
> +
> return mtd_device_unregister(&fsm->mtd);
> }
>
Thanks,
Miquèl
Powered by blists - more mailing lists