linux-kernel - Re: [PATCH V3] dma-buf: ensure unique directory name for dmabuf stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0071e117-1d91-b086-7cb1-976b2a1c3498@amd.com>
Date:   Fri, 13 May 2022 12:29:48 +0200
From:   Christian König <christian.koenig@....com>
To:     Charan Teja Kalla <quic_charante@...cinc.com>,
        Greg KH <gregkh@...uxfoundation.org>
Cc:     sumit.semwal@...aro.org, hridya@...gle.com, daniel.vetter@...ll.ch,
        tjmercier@...gle.com, linux-media@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3] dma-buf: ensure unique directory name for dmabuf stats

Am 13.05.22 um 12:18 schrieb Charan Teja Kalla:
> On 5/13/2022 3:41 PM, Greg KH wrote:
>>> Reported-by: kernel test robot <lkp@...el.com>
>> The trest robot did not say that the dmabuf stat name was being
>> duplicated, did it?
>>
> It reported a printk warning on V2[1]. Should we remove this on V3?

We only add the kernel test robot is report when it found the underlying 
problem and not just noted some warning on an intermediate patch version.

> @Christian: Could you please drop this tag while merging?

Sure, I don't have much on my plate at the moment. But don't let it 
become a habit.

Going to push it upstream through drm-misc-fixes now.

Regards,
Christian.

>
> [1] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F202205110511.E0d8TXXC-lkp%40intel.com%2F&amp;data=05%7C01%7Cchristian.koenig%40amd.com%7C00e38dfb74fb4fe48b8408da34c9ee77%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637880339170888363%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=yH%2FBg2Fjq2ohEFKLgw2CcYEeHiUfgPLlsJaRnt9cKLo%3D&amp;reserved=0
>
>
>>> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
>>> index a6fc96e..0ad5039 100644
>>> --- a/drivers/dma-buf/dma-buf.c
>>> +++ b/drivers/dma-buf/dma-buf.c
>>> @@ -407,6 +407,7 @@ static inline int is_dma_buf_file(struct file *file)
>>>   
>>>   static struct file *dma_buf_getfile(struct dma_buf *dmabuf, int flags)
>>>   {
>>> +	static atomic64_t dmabuf_inode = ATOMIC64_INIT(0);
>>>   	struct file *file;
>>>   	struct inode *inode = alloc_anon_inode(dma_buf_mnt->mnt_sb);
>>>   
>>> @@ -416,6 +417,13 @@ static struct file *dma_buf_getfile(struct dma_buf *dmabuf, int flags)
>>>   	inode->i_size = dmabuf->size;
>>>   	inode_set_bytes(inode, dmabuf->size);
>>>   
>>> +	/*
>>> +	 * The ->i_ino acquired from get_next_ino() is not unique thus
>>> +	 * not suitable for using it as dentry name by dmabuf stats.
>>> +	 * Override ->i_ino with the unique and dmabuffs specific
>>> +	 * value.
>>> +	 */
>>> +	inode->i_ino = atomic64_add_return(1, &dmabuf_inode);
>>>   	file = alloc_file_pseudo(inode, dma_buf_mnt, "dmabuf",
>>>   				 flags, &dma_buf_fops);
>>>   	if (IS_ERR(file))
>>> -- 
>>> 2.7.4
>>>
>> Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Thanks for the ACK.
>
> --Charan