linux-kernel - RE: [PATCH 2/2] random: move initialization out of reseeding hot path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0dc54cecff5400d97f877676d7f11b1@AcuMS.aculab.com>
Date:   Fri, 13 May 2022 11:38:23 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     "'Jason A. Donenfeld'" <Jason@...c4.com>,
        Dominik Brodowski <linux@...inikbrodowski.net>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] random: move initialization out of reseeding hot path

From: Jason A. Donenfeld
> Sent: 13 May 2022 11:22
> 
> On Fri, May 13, 2022 at 08:24:19AM +0200, Dominik Brodowski wrote:
> > > -	if (!crng_ready()) {
> > > -		crng_init = CRNG_READY;
> > > -		finalize_init = true;
> > > -	}
> > > +	crng_init = CRNG_READY;
> >
> > Why unconditionally
> 
> To avoid a useless branch.

Are you now dirtying a cache line that would
otherwise be clean?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)