linux-kernel - Re: [PATCH] can: xilinx_can: Add Transmitter delay compensation (TDC) feature support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 May 2022 13:56:28 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Vincent Mailhol <vincent.mailhol@...il.com>
Cc:     Srinivas Neeli <srinivas.neeli@...inx.com>, wg@...ndegger.com,
        davem@...emloft.net, edumazet@...gle.com,
        appana.durga.rao@...inx.com, sgoud@...inx.com,
        michal.simek@...inx.com, kuba@...nel.org, pabeni@...hat.com,
        linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        git@...inx.com
Subject: Re: [PATCH] can: xilinx_can: Add Transmitter delay compensation
 (TDC) feature support

On 13.05.2022 10:24:06, Vincent Mailhol wrote:
> >  #define XCAN_BTR_SJW_SHIFT             7  /* Synchronous jump width */
> >  #define XCAN_BTR_TS2_SHIFT             4  /* Time segment 2 */
> >  #define XCAN_BTR_SJW_SHIFT_CANFD       16 /* Synchronous jump width */
> > @@ -259,7 +261,7 @@ static const struct can_bittiming_const xcan_bittiming_const_canfd2 = {
> >         .tseg2_min = 1,
> >         .tseg2_max = 128,
> >         .sjw_max = 128,
> > -       .brp_min = 2,
> > +       .brp_min = 1,
> 
> Was there any reason to have brp_min = 2 in the first place?
> I think this change  should be a different patch. If the brp_min = 2
> is just a typo, you might also want to backport it to stable branches.

+1

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)