linux-kernel - Re: [PATCH] lib/atomic64_test.c: convert to use KUnit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ilqa6sjo.fsf@mpe.ellerman.id.au>
Date:   Fri, 13 May 2022 13:05:31 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Daniel Latypov <dlatypov@...gle.com>, brendanhiggins@...gle.com,
        davidgow@...gle.com
Cc:     linux-kernel@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-kselftest@...r.kernel.org, skhan@...uxfoundation.org,
        Daniel Latypov <dlatypov@...gle.com>
Subject: Re: [PATCH] lib/atomic64_test.c: convert to use KUnit

Daniel Latypov <dlatypov@...gle.com> writes:
> The test currently is a bunch of checks (implemented using BUG_ON())
> that can be built into the kernel or as a module.
>
> Convert it to a KUnit test, which can also run in both modes.
> From a user's perspective, this change adds a CONFIG_KUNIT=y dep and
> changes the output format of the test [1]. The test itself is the same.
...

I don't know why I got Cc'ed on this :), but I gave it a quick test anyway.

Seems to work fine on a Power9.
I also flipped some of the conditionals to make sure failure is detected
correctly.

Tested-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)


> Meta:
> 1. this patch applies on top of the kunit branch,
> https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/?h=kunit
>
> 2. checkpatch complains about aligning with parens, but it wants me to
> indent the `#ifdef CONFIG_X86_64` which seems inappropriate in context.
>
> 3. this file doesn't seem to have a clear maintainer, so I assume this
> conversion is fine to go through the kunit branch.

I think you want to at least Cc the atomic folks:

ATOMIC INFRASTRUCTURE
M:	Will Deacon <will@...nel.org>
M:	Peter Zijlstra <peterz@...radead.org>
R:	Boqun Feng <boqun.feng@...il.com>
R:	Mark Rutland <mark.rutland@....com>
L:	linux-kernel@...r.kernel.org
S:	Maintained


cheers